Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: target new spanner db admin service config#1956

Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom
owl-bot-copy
Aug 6, 2022
Merged

fix: target new spanner db admin service config#1956
gcf-merge-on-green[bot] merged 4 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Jul 20, 2022 •
edited
Loading

  • Regenerate this pull request now.

chore: remove old spanner db admin service config
PiperOrigin-RevId: 463110616

Source-Link: googleapis/googleapis@0f38696

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b048ca647e11fc92d5bcf0bec1881d25f321dea9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA0OGNhNjQ3ZTExZmM5MmQ1YmNmMGJlYzE4ODFkMjVmMzIxZGVhOSJ9

feat: Add ListDatabaseRoles API to support role based access control
PiperOrigin-RevId: 462086058

Source-Link: googleapis/googleapis@4f072bf

Source-Link: https://github.com/googleapis/googleapis-gen/commit/06f699da66f7a07b9541e57a7d03863b4df4971c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDZmNjk5ZGE2NmY3YTA3Yjk1NDFlNTdhN2QwMzg2M2I0ZGY0OTcxYyJ9

@gcf-owl-bot
feat: Add ListDatabaseRoles API to support role based access control
bfbeb34 
PiperOrigin-RevId: 462086058

Source-Link: googleapis/googleapis@4f072bf

Source-Link: https://github.com/googleapis/googleapis-gen/commit/06f699da66f7a07b9541e57a7d03863b4df4971c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDZmNjk5ZGE2NmY3YTA3Yjk1NDFlNTdhN2QwMzg2M2I0ZGY0OTcxYyJ9
@gcf-owl-bot gcf-owl-bot Bot requested review from a team July 20, 2022 10:49
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Jul 20, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2022
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jul 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jul 20, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@lqiu96 lqiu96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@lqiu96 lqiu96 removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Jul 25, 2022
@gcf-owl-bot
fix: target new spanner db admin service config
86ce40f 
chore: remove old spanner db admin service config
PiperOrigin-RevId: 463110616

Source-Link: googleapis/googleapis@0f38696

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b048ca647e11fc92d5bcf0bec1881d25f321dea9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA0OGNhNjQ3ZTExZmM5MmQ1YmNmMGJlYzE4ODFkMjVmMzIxZGVhOSJ9
@gcf-owl-bot gcf-owl-bot Bot changed the title feat: Add ListDatabaseRoles API to support role based access control fix: target new spanner db admin service config Jul 25, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jul 25, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jul 25, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 26, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 28, 2022
ansh0l
ansh0l approved these changes Aug 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Aug 3, 2022

@rahul2393 @asthamohta : can one of you review this also reiview this around Session roles etc?

@ansh0l ansh0l requested review from asthamohta and rahul2393 August 3, 2022 05:14
rahul2393
rahul2393 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there will be extra changes needed for databaseRole which I will pull in this PR from main once this one is merged

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 6, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit cb13534 into main Aug 6, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the owl-bot-copy branch August 6, 2022 02:54
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 6, 2022
@release-please release-please Bot mentioned this pull request Aug 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asthamohta asthamohta Awaiting requested review from asthamohta

4 more reviewers

@ansh0l ansh0l ansh0l approved these changes

@lqiu96 lqiu96 lqiu96 approved these changes

@meltsufin meltsufin meltsufin approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ansh0l @lqiu96 @meltsufin @rahul2393 @blakeli0 @yoshi-kokoro