fix tests

sydney-munro · sydney-munro · commit 342afc3e9e65 · 2024-12-06T12:59:46.000-08:00
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcOpenTelemetryTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcOpenTelemetryTest.java
@@ -202,7 +202,7 @@ private void checkCommonAttributes(List<SpanData> spanData) {
       Assert.assertEquals("Storage", getAttributeValue(span, "gcp.client.service"));
       Assert.assertEquals("googleapis/java-storage", getAttributeValue(span, "gcp.client.repo"));
       Assert.assertEquals(
-          "com.google.cloud.google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));
+          "com.google.cloud:google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));
       Assert.assertEquals("grpc", getAttributeValue(span, "rpc.system"));
     }
   }
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/ITHttpOpenTelemetryTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/ITHttpOpenTelemetryTest.java
@@ -206,7 +206,7 @@ private void checkCommonAttributes(List<SpanData> spanData) {
       Assert.assertEquals("Storage", getAttributeValue(span, "gcp.client.service"));
       Assert.assertEquals("googleapis/java-storage", getAttributeValue(span, "gcp.client.repo"));
       Assert.assertEquals(
-          "com.google.cloud.google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));
+          "com.google.cloud:google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));
       Assert.assertEquals("http", getAttributeValue(span, "rpc.system"));
     }
   }
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/ITOpenTelemetryTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/ITOpenTelemetryTest.java
@@ -55,7 +55,7 @@ public void checkInstrumentation() {
     Assert.assertEquals("Storage", getAttributeValue(spanData, "gcp.client.service"));
     Assert.assertEquals("googleapis/java-storage", getAttributeValue(spanData, "gcp.client.repo"));
     Assert.assertEquals(
-        "com.google.cloud.google-cloud-storage",
+        "com.google.cloud:google-cloud-storage",
         getAttributeValue(spanData, "gcp.client.artifact"));
     Assert.assertEquals("http", getAttributeValue(spanData, "rpc.system"));
 
@@ -84,7 +84,7 @@ public void checkInstrumentationGrpc() {
     Assert.assertEquals("Storage", getAttributeValue(spanData, "gcp.client.service"));
     Assert.assertEquals("googleapis/java-storage", getAttributeValue(spanData, "gcp.client.repo"));
     Assert.assertEquals(
-        "com.google.cloud.google-cloud-storage",
+        "com.google.cloud:google-cloud-storage",
         getAttributeValue(spanData, "gcp.client.artifact"));
     Assert.assertEquals("grpc", getAttributeValue(spanData, "rpc.system"));
 

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ private void checkCommonAttributes(List<SpanData> spanData) {`
`202`	`202`	`Assert.assertEquals("Storage", getAttributeValue(span, "gcp.client.service"));`
`203`	`203`	`Assert.assertEquals("googleapis/java-storage", getAttributeValue(span, "gcp.client.repo"));`
`204`	`204`	`Assert.assertEquals(`
`205`		`- "com.google.cloud.google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));`
	`205`	`+ "com.google.cloud:google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));`
`206`	`206`	`Assert.assertEquals("grpc", getAttributeValue(span, "rpc.system"));`
`207`	`207`	`}`
`208`	`208`	`}`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ private void checkCommonAttributes(List<SpanData> spanData) {`
`206`	`206`	`Assert.assertEquals("Storage", getAttributeValue(span, "gcp.client.service"));`
`207`	`207`	`Assert.assertEquals("googleapis/java-storage", getAttributeValue(span, "gcp.client.repo"));`
`208`	`208`	`Assert.assertEquals(`
`209`		`- "com.google.cloud.google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));`
	`209`	`+ "com.google.cloud:google-cloud-storage", getAttributeValue(span, "gcp.client.artifact"));`
`210`	`210`	`Assert.assertEquals("http", getAttributeValue(span, "rpc.system"));`
`211`	`211`	`}`
`212`	`212`	`}`