This repository was archived by the owner on Apr 1, 2026. It is now read-only.
feat: add support for creating a Matrix Factorization model#1330
Merged
feat: add support for creating a Matrix Factorization model#1330
Conversation
…I public dataset In response to feedback on internal change 662899733.
tswast
reviewed
Jan 28, 2025
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Co-authored-by: Tim Sweña (Swast) <[email protected]>
5f4f9d3 to
e5165a9
Compare
tswast
reviewed
Jan 29, 2025
…docs model Co-authored-by: Tim Sweña (Swast) <[email protected]>
…docs fit Co-authored-by: Tim Sweña (Swast) <[email protected]>
tswast
reviewed
Mar 28, 2025
Contributor
|
Re: e2e error This is the correct assertion. Adding a |
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Co-authored-by: Tim Sweña (Swast) <[email protected]>
E Expected: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', trial_id=['index_column_id'])
E Actual: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', index_col=['index_column_id'])
tswast
approved these changes
Apr 1, 2025
Contributor
tswast
left a comment
There was a problem hiding this comment.
So cool! Thanks for your patience and persistence on this.
Several commits added since these changes were requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕