This repository was archived by the owner on Apr 1, 2026. It is now read-only.
fix: ensure page_size works correctly in to_pandas_batches when max_results is not set#1588
Merged
chelsea-lin merged 3 commits intomainfrom Apr 3, 2025
Merged
Conversation
0c3658a to
b162224
Compare
shuoweil
approved these changes
Apr 3, 2025
…n can skip one warning message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue that the
page_sizeis ignored into_pandas_batcheswhenmax_resultsis not set. Also, this change adds code examples for bothto_pandasandto_pandas_batchesand the doctest can verify the fixes.Fixes internal issue 407521010🦕