Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: Support inlining small list, struct, json data#1589

Merged
TrevorBergeron merged 5 commits intomainfrom
almost_anything_inline
Apr 4, 2025
Merged

feat: Support inlining small list, struct, json data#1589
TrevorBergeron merged 5 commits intomainfrom
almost_anything_inline

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

@TrevorBergeron TrevorBergeron commented Apr 3, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 3, 2025
@TrevorBergeron TrevorBergeron force-pushed the almost_anything_inline branch from fc4e2ea to fc4b243 Compare April 4, 2025 00:27
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 4, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review April 4, 2025 00:28
@TrevorBergeron TrevorBergeron requested review from a team and jialuoo April 4, 2025 00:28
chelsea-lin
chelsea-lin approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

tests/unit/session/test_session.py
session.read_pandas(df, write_engine="bigquery_inline")


def test_read_pandas_inline_w_noninlineable_type_raises_error():
Copy link
Copy Markdown
Contributor

@chelsea-lin chelsea-lin Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this test for Geo data?

@TrevorBergeron TrevorBergeron mentioned this pull request Apr 4, 2025
Closed
4 tasks
@arwas11 arwas11 removed their assignment Apr 4, 2025
@TrevorBergeron TrevorBergeron merged commit 2ce891f into main Apr 4, 2025
23 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the almost_anything_inline branch April 4, 2025 19:14
@release-please release-please bot mentioned this pull request Apr 4, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jialuoo jialuoo Awaiting requested review from jialuoo

1 more reviewer

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @chelsea-lin @arwas11