This repository was archived by the owner on Apr 1, 2026. It is now read-only.
feat: add Series.cov method#368
Merged
gcf-merge-on-green[bot] merged 3 commits intomainfrom Feb 7, 2024
Merged
Conversation
chelsea-lin
approved these changes
Feb 6, 2024
Contributor
chelsea-lin
left a comment
There was a problem hiding this comment.
LGTM. Can I add Dataframes.cov based on this commit?
| left_numeric = cast(ibis_types.NumericColumn, left) | ||
| right_numeric = cast(ibis_types.NumericColumn, right) | ||
| bq_cov = _apply_window_if_present( | ||
| left_numeric.cov(right_numeric, how="sample"), window |
Contributor
There was a problem hiding this comment.
what's how='sample' meaning here? Do we calculate the cov based on a sample series?
Contributor
Author
There was a problem hiding this comment.
Sample variance often means it is population_variance * N / N-1. This provides an unbiased estimator of variance https://mathworld.wolfram.com/SampleVariance.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕