This repository was archived by the owner on Apr 1, 2026. It is now read-only.
Merged
Conversation
475eeea to
9a56bb5
Compare
bigframes/core/compile/compiled.py
Outdated
Comment on lines
+789
to
+793
| zip_array = ( | ||
| table_w_offset[offset_array_id] | ||
| .zip(*[table_w_offset[column_id] for column_id in column_ids]) | ||
| .name(zip_array_id) | ||
| ) |
Contributor
There was a problem hiding this comment.
Have you tried directly indexing using the offsets rather than zipping? I'm worried compiling this creates an extra correlated JOIN.
Contributor
Author
There was a problem hiding this comment.
Thanks! The new logical has a better performance!
| ), | ||
| ], | ||
| ) | ||
| def test_series_explode(data): |
Contributor
There was a problem hiding this comment.
I'm not sure if any of these tests use the unordered path. Maybe use to_pandas(ordered=False) for a test or two? Also for unordered test cases make sure not to ignore index as resetting the index will invoke the ordered path.
Contributor
Author
There was a problem hiding this comment.
It looks dtype validation will trigger the unordered path. Also I added the aggregation and to_pandas(ordered=False) as you suggested. Thanks!
b648bdb to
9aef5a3
Compare
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat: (Series|DataFrame).explode * fixing schema and adding tests * fixing multi-index tests * add docs and fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕