This repository was archived by the owner on Feb 26, 2026. It is now read-only.
fix: properly handle None from metadata server#718
Merged
daniel-sanche merged 6 commits intomainfrom Feb 1, 2023
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library doesn't properly handle partial data from the metadata server. If the server returns some values, but None for others, the library will raise an error when it tries to log the None values
This PR addresses this by returning empty strings for any missing values, rather than None
Fixes #710