Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sqlcipher/android-database-sqlcipher
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: greysonp/android-database-sqlcipher
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Apr 17, 2018

  1. Limit memory usage, improve cursor read throughput. 

    Migrated over the original implementation of CursorWindow#allocate so
that it respects the maximum memory limit.

Also, increased ROW_SLOT_CHUNK_NUM_ROWS to 256, improving allocation
speed and drastically increasing the throughput of cursor reads. That
value determines how many row_slot_t's are allocated, which is just a
struct wrapping a uint32_t, so increasing the number allocated at once
shouldn't be a huge deal from a memory usage perspective. The value 256
was chosen after testing with a variety of devices. It appeared to be
the size where you had diminishing returns on cursor filling
performance.
    @greysonp
    greysonp committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    2e0aadc View commit details
    Browse the repository at this point in the history
Loading