From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

From: Navid Emamdoost <[email protected]>

Date: Tue, 24 Sep 2019 20:20:21 -0500

Subject: [PATCH] rtlwifi: prevent memory leak in rtl_usb_probe

In rtl_usb_probe if allocation for usb_data fails the allocated hw

should be released. In addition the allocated rtlpriv->usb_data should

be released on error handling path.

Signed-off-by: Navid Emamdoost <[email protected]>

Signed-off-by: Kalle Valo <[email protected]>

drivers/net/wireless/realtek/rtlwifi/usb.c | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

index 4b59f3b46b28..348b0072cdd6 100644

@@ -1021,8 +1021,10 @@ int rtl_usb_probe(struct usb_interface *intf,

rtlpriv->hw = hw;

rtlpriv->usb_data = kcalloc(RTL_USB_MAX_RX_COUNT, sizeof(u32),

GFP_KERNEL);

return -ENOMEM;

/* this spin lock must be initialized early */

spin_lock_init(&rtlpriv->locks.usb_lock);

@@ -1083,6 +1085,7 @@ int rtl_usb_probe(struct usb_interface *intf,

_rtl_usb_io_handler_release(hw);

usb_put_dev(udev);

complete(&rtlpriv->firmware_loading_complete);

return -ENODEV;

}

EXPORT_SYMBOL(rtl_usb_probe);

https://clearlinux.org