linux/CVE-2019-19064.patch at master · hainesbg/linux

35 lines (30 loc) · 1.32 KB

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

From: Navid Emamdoost <[email protected]>

Date: Sun, 29 Sep 2019 22:46:01 -0500

Subject: [PATCH] spi: lpspi: fix memory leak in fsl_lpspi_probe

In fsl_lpspi_probe an SPI controller is allocated either via

spi_alloc_slave or spi_alloc_master. In all but one error cases this

controller is put by going to error handling code. This commit fixes the

case when pm_runtime_get_sync fails and it should go to the error

handling path.

Fixes: 944c01a889d9 ("spi: lpspi: enable runtime pm for lpspi")

Signed-off-by: Navid Emamdoost <[email protected]>

Link: https://lore.kernel.org/r/[email protected]

Signed-off-by: Mark Brown <[email protected]>

---

drivers/spi/spi-fsl-lpspi.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c

index d08e9324140e..3528ed5eea9b 100644

--- a/drivers/spi/spi-fsl-lpspi.c

+++ b/drivers/spi/spi-fsl-lpspi.c

@@ -938,7 +938,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)

ret = pm_runtime_get_sync(fsl_lpspi->dev);

if (ret < 0) {

dev_err(fsl_lpspi->dev, "failed to enable clock\n");

- return ret;

+ goto out_controller_put;

}

temp = readl(fsl_lpspi->base + IMX7ULP_PARAM);

https://clearlinux.org

Provide feedback