Skip to content

New heuristic for getting rid of unnecessary "antialias-lines".#12695

Merged
unknownbrackets merged 1 commit intomasterfrom
new-aa-line-heuristic
Mar 10, 2020
Merged

New heuristic for getting rid of unnecessary "antialias-lines".#12695
unknownbrackets merged 1 commit intomasterfrom
new-aa-line-heuristic

Conversation

@hrydgard
Copy link
Copy Markdown
Owner

@hrydgard hrydgard commented Mar 9, 2020

Should fix #12558, while keeping the other AA line issues also fixed.

Heuristic derived from unknown's experiment reports and discussion in #12558 and #6483.

Should fix #12558, while keeping the other aa line issues also fixed.

Heuristic derived from discussions in #12558 and #6483.
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Mar 9, 2020
@hrydgard hrydgard added this to the v1.10.0 milestone Mar 9, 2020
@unknownbrackets
Copy link
Copy Markdown
Collaborator

Ah, is DOA confirmed to use REPLACE too? Seems reasonable.

-[Unknown]

@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 9, 2020

Not 100% confirmed, but highly suspected since it uses the same technique for antialiasing and not line drawing. I expect angry reports if I'm wrong given what it looks like without the heuristic :) Maybe there's a GE framedump somewhere..

@unknownbrackets unknownbrackets merged commit af604b1 into master Mar 10, 2020
@hrydgard hrydgard deleted the new-aa-line-heuristic branch March 26, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GE emulation Backend-independent GPU issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persona 3 Portable Lines in Tartarus transformation scene

2 participants