Skip to content

Support drawing around notches on Android displays. Fixes #12261#12779

Merged
unknownbrackets merged 1 commit intomasterfrom
notch-support
Mar 31, 2020
Merged

Support drawing around notches on Android displays. Fixes #12261#12779
unknownbrackets merged 1 commit intomasterfrom
notch-support

Conversation

@hrydgard
Copy link
Copy Markdown
Owner

@hrydgard hrydgard commented Mar 30, 2020

Finally finished this up, but I'm struggling to see the point - all phones with notches are so wide anyway that you don't get any additional PSP display area, and do you really want to put controls out there in the limit? You'll just smudge up the camera. Anyway, it's not really any worse so...

Here's what it looks like on a Pocophone F1:

20200331_004144

@hrydgard hrydgard added this to the v1.10.0 milestone Mar 30, 2020
@hrydgard hrydgard mentioned this pull request Mar 30, 2020
Closed
@Panderner
Copy link
Copy Markdown
Contributor

Panderner commented Mar 30, 2020 •
edited
Loading

How about iPhone X, XS, XR and 11?

unknownbrackets
unknownbrackets approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, the menu looks better with the background behind it, at least.

-[Unknown]

@unknownbrackets unknownbrackets merged commit 3965341 into master Mar 31, 2020
@unknownbrackets
Copy link
Copy Markdown
Collaborator

unknownbrackets commented Mar 31, 2020

This makes it easier to implement any similar change for iOS devices, but doesn't actually get the notch information from iOS. Contributions welcome.

-[Unknown]

@Panderner
Copy link
Copy Markdown
Contributor

Panderner commented Mar 31, 2020

Reverse landscape mode doesn't seem to be right

@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 31, 2020

@Panderner can you take a picture?

@hrydgard hrydgard deleted the notch-support branch March 31, 2020 13:21
@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 31, 2020

Ah, I see, I could repro. When going directly from landscape to reverse landscape, it doesn't update the margins properly. I guess we might be doing the checks in the wrong place, I'll get this fixed.

hrydgard added a commit that referenced this pull request Mar 31, 2020
@hrydgard
Fix landscape/reverse landscape cutout padding issue, see #12779
7dfe895
@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 31, 2020

Pushed a fix, should be ok now.

@Panderner
Copy link
Copy Markdown
Contributor

Panderner commented Mar 31, 2020 •
edited
Loading

And how about Touchscreen test and GPU Driver Test at the developer tools menu? The letters blocked by the notch.

@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 31, 2020

Oh, right, thanks for reminding me about those. They indeed don't properly take the notch into account, I'll fix them up later.

hrydgard referenced this pull request Mar 31, 2020
@hrydgard
Additional rendering fixes for notch
f01a4a3
@hrydgard
Copy link
Copy Markdown
Owner Author

hrydgard commented Mar 31, 2020

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unknownbrackets unknownbrackets unknownbrackets approved these changes

Assignees

No one assigned

Labels

Platform-specific (Android)

Projects

None yet

Milestone

v1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hrydgard @Panderner @unknownbrackets