D3D9: Fix a sign mistake generating the projection matrix.#13071
Merged
unknownbrackets merged 1 commit intomasterfrom Jun 28, 2020
Merged
D3D9: Fix a sign mistake generating the projection matrix.#13071unknownbrackets merged 1 commit intomasterfrom
unknownbrackets merged 1 commit intomasterfrom
Conversation
unknownbrackets
approved these changes
Jun 28, 2020
Collaborator
unknownbrackets
left a comment
There was a problem hiding this comment.
At least, this seems like a straight-forward mistake in 41a6b97.
I think we could probably auto-run tests to compare GE dumps, although I worry about slight pixel differences. I feel like Dolphin's stuff got quite complicated to handle that...
-[Unknown]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13063
I hope we don't break something else...
We really need some kind of regression tests for this stuff..