http: Check cancel flag more often#13095
Merged
hrydgard merged 1 commit intohrydgard:masterfrom Jul 5, 2020
Merged
Conversation
Would be better to use non-blocking sockets, but this code is working, so not planning to rewrite it right now.
Owner
|
Thanks! Ideally we should probably switch to some trusted crossplatform all in one solution for http downloads, or use platform specific stuff like the Android Download Manager. But yeah, not now. And I don't know what that crossplatform solution would be... I'm gonna test this on a few platforms, and then probably merge in to 1.10.2. |
Owner
|
Somehow this seems to greatly improve download speed on both Windows and Android? Can't complain :) Will try on Mac too and a couple of old Android devices, then merge if all goes well. |
Collaborator
Author
|
Interesting. It seemed faster to me too but I wasn't sure. It should process the buffer more efficiently but greatly is a bit unexpected. -[Unknown] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be better to use non-blocking sockets, but this code is working, so not planning to rewrite it right now.
This just makes us run
select()on sockets before reading/writing to them. Before, we would try to write, and only timeout if we got data slowly. In a situation where the user loses signal,recv()will just block. In other places, we were using a timeout - but only checking at the end of the entire timeout.Now, we check the cancel flag in small chunks of 0.25s waits. So if the user loses connectivity, it won't just wait and wait.
Actual behavior with a good connection should not be impacted.
-[Unknown]