Add iOS version detection, turn off JIT on bootup if >= 14.3.#14201
Merged
unknownbrackets merged 2 commits intomasterfrom Feb 22, 2021
Merged
Add iOS version detection, turn off JIT on bootup if >= 14.3.#14201unknownbrackets merged 2 commits intomasterfrom
unknownbrackets merged 2 commits intomasterfrom
Conversation
unknownbrackets
requested changes
Feb 22, 2021
Collaborator
unknownbrackets
left a comment
There was a problem hiding this comment.
Definitely needs app-android.cpp, no?
-[Unknown]
| bool System_GetPropertyBool(SystemProperty prop) { | ||
| switch (prop) { | ||
| case SYSPROP_CAN_JIT: | ||
| return true; |
Collaborator
There was a problem hiding this comment.
Thanks for remembering, sometimes seems like headless always gets last pick. Though indentation is a bit spacier than usual.
-[Unknown]
Collaborator
|
Seems libretro won't even hit this code, so we only need Android left. -[Unknown] |
a2899b8 to
21511ac
Compare
Owner
Author
|
I had actually done Android too, it was just sitting unsaved in my editor for some reason. |
unknownbrackets
approved these changes
Feb 22, 2021
|
Shouldn't this be >= 14.4? JIT still works on 14.3 (on A12 and up). |
Owner
Author
|
I was under the impression it worked on 12.2 but not later, apparently I was a minor version off. Can fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a bit undecided on exactly what we should do.
"Fixes" #14196
Options seem to be:
In the two second options, the user can still attempt to turn it on in case Apple makes a boo-boo and accidentally allows it again.
This implements the building blocks, and option 3 above.
Hm.