Test improved

daquinoaldo · daquinoaldo · commit 3d30cc20fe47 · 2019-02-11T21:15:19.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -94,11 +94,4 @@ node_js:
 - 7.7.1
 - 7.7.0
 - 7.6
-- 7.5
-- 7.4
-- 7.3
-- 7.2.1
-- 7.2.0
-- 7.1
-- 7.0
 after_success: npm run coveralls
diff --git a/README.md b/README.md
@@ -67,6 +67,10 @@ Checkout the updated list [here](https://github.com/FiloSottile/mkcert/blob/mast
 - Java (when `JAVA_HOME` is set)
 
 
+## Troubleshooting
+https-localhost requires Node.js 7.6 or higher.  
+<small>If you need compatibility with previously Node.js versions let me know, I'll try to rearrange the code.</small>
+
 ## License
 Is released under [AGPL-3.0 - GNU Affero General Public License v3.0](LICENSE).
 
diff --git a/test/test.js b/test/test.js
@@ -80,6 +80,22 @@ describe("Testing https-localhost", () => {
         res.data.toString() === fs.readFileSync("test/static.html").toString()))
   })
 
+  it("doesn't crash on 404", async function() {
+    // start the server (serving the default folder)
+    app.serve()
+    // make the request and check the status code
+    await makeRequest("/do-not-exist")
+      .then(res => assert(res.statusCode === 404))
+  })
+
+  it("doesn't crash if the static path doesn't exists", async function() {
+    // start the server (serving a non existing folder)
+    app.serve("do-not-exists")
+    // make the request and check the status code
+    await makeRequest("/")
+      .then(res => assert(res.statusCode === 404))
+  })
+
   it("redirect http to https", async function() {
     // start the redirection
     await app.redirect(HTTP_PORT)

-Original file line number
+Diff line change
 - 7.7.1
 - 7.7.0
 - 7.6
 -- 7.5
 -- 7.4
 -- 7.3
 -- 7.2.1
 -- 7.2.0
 -- 7.1
 -- 7.0
 after_success: npm run coveralls