Conversation
…from writing to storage.
…orage access library to allow developer-related storage reads/writes.
…ns to prevent stack too deep error.
…ssion of new product versions, and voting for approval of these versions.
… versions and finalize voting on submitted versions.
…ruffle tests for Administration.
highruned
reviewed
Aug 15, 2018
| retBytes32 := mload(add(inBytes, /* BYTES_HEADER_SIZE */ 32)) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Our eternal storage to be as generic as possible, it has a mapping of bytes, except for author tags that have byte32, but they aren't compatible. If you add them, you can't. So you have to convert the bytes32 to a bytes first. And to ensure you can use them in reverse you have to convert back.
highruned
approved these changes
Aug 15, 2018
Contributor
|
👍 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.