Skip to content

Commit 46d5c38

Browse files
iliabylichiliabylich
committed
rubocop -a stdlib
1 parent 0acaf40 commit 46d5c38

38 files changed

Lines changed: 505 additions & 490 deletions

‎.rubocop.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ AllCops:
4646
- 'stdlib/observer.rb'
4747
- 'stdlib/open-uri.rb'
4848
- 'stdlib/stringio.rb'
49+
- 'stdlib/source_map/*.rb'
4950
- 'stdlib/racc/parser.rb'
5051

5152
Naming/MethodName:
@@ -76,6 +77,7 @@ Layout/EmptyLineAfterMagicComment:
7677
Style/GlobalVars:
7778
Exclude:
7879
- 'opal/corelib/kernel.rb'
80+
- 'stdlib/nodejs/irb.rb'
7981

8082
Layout/ExtraSpacing:
8183
Exclude:

‎.rubocop_todo.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,6 @@ Style/ModuleFunction:
3535
Style/MutableConstant:
3636
Exclude:
3737
- 'opal/**/*.rb'
38+
- 'stdlib/**/*.rb'
3839
- 'lib/opal/nodes/call.rb'
3940
- 'lib/opal/util.rb'

‎stdlib/base64.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def self.urlsafe_decode64(string)
7878

7979
def self.urlsafe_encode64(string, padding: true)
8080
str = `encode(string).replace(/\+/g, '-').replace(/\//g, '_')`
81-
str = str.delete("=") unless padding
81+
str = str.delete('=') unless padding
8282
str
8383
end
8484
end

‎stdlib/bigdecimal.rb‎

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,12 @@ def ==(other)
5858
alias === ==
5959

6060
def <=>(other)
61-
case other
62-
when self.class
63-
result = bignumber.JS.comparedTo(other.bignumber)
64-
when Number
65-
result = bignumber.JS.comparedTo(other)
66-
else
67-
result = nil
68-
end
61+
result = case other
62+
when self.class
63+
bignumber.JS.comparedTo(other.bignumber)
64+
when Number
65+
bignumber.JS.comparedTo(other)
66+
end
6967
`#{result} === null ? nil : #{result}`
7068
end
7169

@@ -94,7 +92,7 @@ def abs
9492
end
9593

9694
def add(other, digits = 0)
97-
if digits == nil
95+
if digits.nil?
9896
raise TypeError, 'wrong argument type nil (expected Fixnum)'
9997
end
10098

@@ -120,7 +118,7 @@ def ceil(n = nil)
120118
raise FloatDomainError, "Computation results to 'Infinity'"
121119
end
122120

123-
if n == nil
121+
if n.nil?
124122
bignumber.JS.round(0, ROUND_CEILING).JS.toNumber
125123
elsif n >= 0
126124
self.class.new(bignumber.JS.round(n, ROUND_CEILING))
@@ -149,9 +147,9 @@ def div(other, digits = nil)
149147
raise FloatDomainError, "Computation results to 'NaN'(Not a Number)"
150148
end
151149

152-
if digits == nil
150+
if digits.nil?
153151
if other.zero?
154-
raise ZeroDivisionError, "divided by 0"
152+
raise ZeroDivisionError, 'divided by 0'
155153
end
156154

157155
if infinite?
@@ -183,7 +181,7 @@ def minus(other)
183181
def mult(other, digits = nil)
184182
other, _ = coerce(other)
185183

186-
if digits == nil
184+
if digits.nil?
187185
return self.class.new(bignumber.JS.times(other.bignumber))
188186
end
189187

‎stdlib/buffer.rb‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@ class Buffer
66
include Native::Wrapper
77

88
def self.supported?
9-
not $$[:ArrayBuffer].nil?
9+
!$$[:ArrayBuffer].nil?
1010
end
1111

1212
def self.name_for(bits, type)
13-
"#{case type
14-
when :unsigned then 'Uint'
15-
when :signed then 'Int'
16-
when :float then 'Float'
17-
end}#{bits}"
13+
part = case type
14+
when :unsigned then 'Uint'
15+
when :signed then 'Int'
16+
when :float then 'Float'
17+
end
18+
"#{part}#{bits}"
1819
end
1920

2021
def initialize(size, bits = 8)
@@ -26,7 +27,7 @@ def initialize(size, bits = 8)
2627
end
2728

2829
def length
29-
`#@native.byteLength`
30+
`#{@native}.byteLength`
3031
end
3132

3233
alias size length

‎stdlib/buffer/array.rb‎

Lines changed: 46 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,68 +1,66 @@
11
class Buffer
2+
class Array
3+
include Native::Wrapper
24

3-
class Array
4-
include Native::Wrapper
5+
def self.for(bits, type)
6+
$$["#{Buffer.name_for bits, type}Array"]
7+
end
58

6-
def self.for(bits, type)
7-
$$["#{Buffer.name_for bits, type}Array"]
8-
end
9+
include Enumerable
910

10-
include Enumerable
11+
attr_reader :buffer, :type
1112

12-
attr_reader :buffer, :type
13+
def initialize(buffer, bits = nil, type = nil)
14+
if Native == buffer
15+
super(buffer)
16+
else
17+
%x{
18+
var klass = #{Array.for(bits, type)};
1319
14-
def initialize(buffer, bits = nil, type = nil)
15-
if Native == buffer
16-
super(buffer)
17-
else
18-
%x{
19-
var klass = #{Array.for(bits, type)};
20+
#{super(`new klass(#{buffer.to_n})`)}
21+
}
22+
end
2023

21-
#{super(`new klass(#{buffer.to_n})`)}
22-
}
24+
@buffer = buffer
25+
@type = type
2326
end
2427

25-
@buffer = buffer
26-
@type = type
27-
end
28-
29-
def bits
30-
`#@native.BYTES_PER_ELEMENT * 8`
31-
end
28+
def bits
29+
`#{@native}.BYTES_PER_ELEMENT * 8`
30+
end
3231

33-
def [](index, offset = nil)
34-
offset ? `#@native.subarray(index, offset)` : `#@native[index]`
35-
end
32+
def [](index, offset = nil)
33+
offset ? `#{@native}.subarray(index, offset)` : `#{@native}[index]`
34+
end
3635

37-
def []=(index, value)
38-
`#@native[index] = value`
39-
end
36+
def []=(index, value)
37+
`#{@native}[index] = value`
38+
end
4039

41-
def bytesize
42-
`#@native.byteLength`
43-
end
40+
def bytesize
41+
`#{@native}.byteLength`
42+
end
4443

45-
def each
46-
return enum_for :each unless block_given?
44+
def each
45+
return enum_for :each unless block_given?
4746

48-
%x{
49-
for (var i = 0, length = #@native.length; i < length; i++) {
50-
#{yield `#@native[i]`}
47+
%x{
48+
for (var i = 0, length = #{@native}.length; i < length; i++) {
49+
#{yield `#{@native}[i]`}
50+
}
5151
}
52-
}
5352

54-
self
55-
end
56-
57-
def length
58-
`#@native.length`
59-
end
53+
self
54+
end
6055

61-
def merge!(other, offset = undefined)
62-
`#@native.set(#{other.to_n}, offset)`
63-
end
56+
def length
57+
`#{@native}.length`
58+
end
6459

65-
alias size length
66-
end
60+
def merge!(other, offset = undefined)
61+
`#{@native}.set(#{other.to_n}, offset)`
62+
end
6763

64+
alias size length
65+
end
6866
end

‎stdlib/buffer/view.rb‎

Lines changed: 85 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,108 @@
11
class Buffer
2+
class View
3+
include Native::Wrapper
24

3-
class View
4-
include Native::Wrapper
5+
def self.supported?
6+
!$$[:DataView].nil?
7+
end
58

6-
def self.supported?
7-
not $$[:DataView].nil?
8-
end
9+
attr_reader :buffer, :offset
10+
11+
def initialize(buffer, offset = nil, length = nil)
12+
if native?(buffer)
13+
super(buffer)
14+
elsif offset && length
15+
super(`new DataView(#{buffer.to_n}, #{offset.to_n}, #{length.to_n})`)
16+
elsif offset
17+
super(`new DataView(#{buffer.to_n}, #{offset.to_n})`)
18+
else
19+
super(`new DataView(#{buffer.to_n})`)
20+
end
21+
22+
@buffer = buffer
23+
@offset = offset
24+
end
25+
26+
def length
27+
`#{@native}.byteLength`
28+
end
929

10-
attr_reader :buffer, :offset
30+
alias size length
1131

12-
def initialize(buffer, offset = nil, length = nil)
13-
if native?(buffer)
14-
super(buffer)
15-
elsif offset && length
16-
super(`new DataView(#{buffer.to_n}, #{offset.to_n}, #{length.to_n})`)
17-
elsif offset
18-
super(`new DataView(#{buffer.to_n}, #{offset.to_n})`)
19-
else
20-
super(`new DataView(#{buffer.to_n})`)
32+
def get(offset, bits = 8, type = :unsigned, little = false)
33+
`#{@native}["get" + #{Buffer.name_for bits, type}](offset, little)`
2134
end
2235

23-
@buffer = buffer
24-
@offset = offset
25-
end
36+
alias [] get
2637

27-
def length
28-
`#@native.byteLength`
29-
end
38+
def set(offset, value, bits = 8, type = :unsigned, little = false)
39+
`#{@native}["set" + #{Buffer.name_for bits, type}](offset, value, little)`
40+
end
3041

31-
alias size length
42+
alias []= set
3243

33-
def get(offset, bits = 8, type = :unsigned, little = false)
34-
`#@native["get" + #{Buffer.name_for bits, type}](offset, little)`
35-
end
44+
def get_int8(offset, little = false)
45+
`#{@native}.getInt8(offset, little)`
46+
end
3647

37-
alias [] get
48+
def set_int8(offset, value, little = false)
49+
`#{@native}.setInt8(offset, value, little)`
50+
end
3851

39-
def set(offset, value, bits = 8, type = :unsigned, little = false)
40-
`#@native["set" + #{Buffer.name_for bits, type}](offset, value, little)`
41-
end
52+
def get_uint8(offset, little = false)
53+
`#{@native}.getUint8(offset, little)`
54+
end
4255

43-
alias []= set
56+
def set_uint8(offset, value, little = false)
57+
`#{@native}.setUint8(offset, value, little)`
58+
end
4459

45-
def get_int8(offset, little = false); `#@native.getInt8(offset, little)`; end
46-
def set_int8(offset, value, little = false); `#@native.setInt8(offset, value, little)`; end
60+
def get_int16(offset, little = false)
61+
`#{@native}.getInt16(offset, little)`
62+
end
4763

48-
def get_uint8(offset, little = false); `#@native.getUint8(offset, little)`; end
49-
def set_uint8(offset, value, little = false); `#@native.setUint8(offset, value, little)`; end
64+
def set_int16(offset, value, little = false)
65+
`#{@native}.setInt16(offset, value, little)`
66+
end
5067

51-
def get_int16(offset, little = false); `#@native.getInt16(offset, little)`; end
52-
def set_int16(offset, value, little = false); `#@native.setInt16(offset, value, little)`; end
68+
def get_uint16(offset, little = false)
69+
`#{@native}.getUint16(offset, little)`
70+
end
5371

54-
def get_uint16(offset, little = false); `#@native.getUint16(offset, little)`; end
55-
def set_uint16(offset, value, little = false); `#@native.setUint16(offset, value, little)`; end
72+
def set_uint16(offset, value, little = false)
73+
`#{@native}.setUint16(offset, value, little)`
74+
end
5675

57-
def get_int32(offset, little = false); `#@native.getInt32(offset, little)`; end
58-
def set_int32(offset, value, little = false); `#@native.setInt32(offset, value, little)`; end
76+
def get_int32(offset, little = false)
77+
`#{@native}.getInt32(offset, little)`
78+
end
5979

60-
def get_uint32(offset, little = false); `#@native.getUint32(offset, little)`; end
61-
def set_uint32(offset, value, little = false); `#@native.setUint32(offset, value, little)`; end
80+
def set_int32(offset, value, little = false)
81+
`#{@native}.setInt32(offset, value, little)`
82+
end
6283

63-
def get_float32(offset, little = false); `#@native.getFloat32(offset, little)`; end
64-
def set_float32(offset, value, little = false); `#@native.setFloat32(offset, value, little)`; end
84+
def get_uint32(offset, little = false)
85+
`#{@native}.getUint32(offset, little)`
86+
end
6587

66-
def get_float64(offset, little = false); `#@native.getFloat64(offset, little)`; end
67-
def set_float64(offset, value, little = false); `#@native.setFloat64(offset, value, little)`; end
68-
end
88+
def set_uint32(offset, value, little = false)
89+
`#{@native}.setUint32(offset, value, little)`
90+
end
6991

92+
def get_float32(offset, little = false)
93+
`#{@native}.getFloat32(offset, little)`
94+
end
95+
96+
def set_float32(offset, value, little = false)
97+
`#{@native}.setFloat32(offset, value, little)`
98+
end
99+
100+
def get_float64(offset, little = false)
101+
`#{@native}.getFloat64(offset, little)`
102+
end
103+
104+
def set_float64(offset, value, little = false)
105+
`#{@native}.setFloat64(offset, value, little)`
106+
end
107+
end
70108
end

0 commit comments

Comments
 (0)