fix(bump): run pre-bump extensions before plugin validation (#175)

indaco · web-flow · commit 8621801e971d · 2026-01-23T11:10:53.000+01:00
Swapped execution order so pre-bump extension hooks run before pre-bump plugin validations. This allows extensions to set up state (e.g., modify .version file) that plugins need to validate. Also added logic to re-read the .version file after extensions run, in case an extension modified it. Fixes #173
diff --git a/cmd/sley/bumpcmd/bump_plugins_test.go b/cmd/sley/bumpcmd/bump_plugins_test.go
@@ -562,6 +562,52 @@ func TestSingleModuleBump_ValidateDependencyConsistencyFails(t *testing.T) {
 	}
 }
 
+func TestSingleModuleBump_ValidateDependencyConsistencyWithAutoSync(t *testing.T) {
+	tmpDir := t.TempDir()
+	versionPath := filepath.Join(tmpDir, ".version")
+	testutils.WriteTempVersionFile(t, tmpDir, "1.0.0")
+
+	// Create package.json with different version
+	pkgPath := filepath.Join(tmpDir, "package.json")
+	if err := os.WriteFile(pkgPath, []byte(`{"version": "0.9.0"}`), 0644); err != nil {
+		t.Fatal(err)
+	}
+
+	// Save and restore
+	origGetDependencyCheckerFn := dependencycheck.GetDependencyCheckerFn
+	defer func() { dependencycheck.GetDependencyCheckerFn = origGetDependencyCheckerFn }()
+
+	// Create dependency checker with auto-sync enabled - should NOT fail on inconsistencies
+	plugin := dependencycheck.NewDependencyChecker(&dependencycheck.Config{
+		Enabled:  true,
+		AutoSync: true, // This should cause the validation to pass
+		Files: []dependencycheck.FileConfig{
+			{Path: pkgPath, Field: "version", Format: "json"},
+		},
+	})
+
+	cfg := &config.Config{Path: versionPath}
+	registry := plugins.NewPluginRegistry()
+	if err := registry.RegisterDependencyChecker(plugin); err != nil {
+		t.Fatalf("failed to register dependency checker: %v", err)
+	}
+	appCli := testutils.BuildCLIForTests(cfg.Path, []*cli.Command{Run(cfg, registry)})
+
+	// With auto-sync enabled, bump should succeed even with inconsistent versions
+	err := appCli.Run(context.Background(), []string{
+		"sley", "bump", "major",
+	})
+	if err != nil {
+		t.Errorf("expected no error with auto-sync enabled, got: %v", err)
+	}
+
+	// Verify the version was bumped
+	got := testutils.ReadTempVersionFile(t, tmpDir)
+	if got != "2.0.0" {
+		t.Errorf("expected version 2.0.0, got %q", got)
+	}
+}
+
 func TestValidateDependencyConsistency_AutoSyncSkipsError(t *testing.T) {
 	tmpDir := t.TempDir()
 
diff --git a/cmd/sley/bumpcmd/common.go b/cmd/sley/bumpcmd/common.go
@@ -52,13 +52,25 @@ func executeSingleModuleBump(
 	// Apply pre-release and build metadata
 	newVersion.Build = calculateNewBuild(params.meta, params.preserveMeta, previousVersion.Build)
 
-	// Execute all pre-bump validations
-	if err := executePreBumpValidations(registry, newVersion, previousVersion, params.bumpType); err != nil {
+	// Run pre-bump extension hooks first - extensions may set up state that plugins need to validate
+	if err := runPreBumpExtensionHooks(ctx, cfg, execCtx.Path, newVersion.String(), previousVersion.String(), params.bumpType, params.skipHooks); err != nil {
 		return err
 	}
 
-	// Run pre-bump extension hooks
-	if err := runPreBumpExtensionHooks(ctx, cfg, execCtx.Path, newVersion.String(), previousVersion.String(), params.bumpType, params.skipHooks); err != nil {
+	// Re-read the current version in case an extension modified the .version file
+	// (e.g., an extension that fetches the latest release from GitHub and updates .version)
+	if !params.skipHooks {
+		previousVersion, err = semver.ReadVersion(execCtx.Path)
+		if err != nil {
+			return err
+		}
+		// Recalculate the new version based on the potentially updated previous version
+		newVersion = params.versionCalc(previousVersion)
+		newVersion.Build = calculateNewBuild(params.meta, params.preserveMeta, previousVersion.Build)
+	}
+
+	// Execute all pre-bump validations after extensions have run
+	if err := executePreBumpValidations(registry, newVersion, previousVersion, params.bumpType); err != nil {
 		return err
 	}
 
