Some bugfixes and PHPDoc improvements#301
Closed
mkkeck wants to merge 1 commit intoj4mie:developfrom
mkkeck:develop
Closed
Some bugfixes and PHPDoc improvements#301mkkeck wants to merge 1 commit intoj4mie:developfrom mkkeck:develop
mkkeck wants to merge 1 commit intoj4mie:developfrom
mkkeck:develop
Conversation
Undefined variable '$value' (see line #1470):
```php
public function having_id_is($id) {
return (is_array($this->_get_id_column_name())) ?
$this->having($this->_get_compound_id_column_values($value)) :
$this->having($this->_get_id_column_name(), $id);
}
```
Correct
```php
public function having_id_is($id) {
return (is_array($this->_get_id_column_name())) ?
$this->having($this->_get_compound_id_column_values($id)) :
$this->having($this->_get_id_column_name(), $id);
}
```
In most cases using the same variable as a key or value both by the onner and outer 'foreach' loop either is an error or may result in an error in future (see line #1254):
```php
public function where_any_is($values, $operator='=') {
$data = array();
$query = array("((");
$first = true;
foreach ($values as $item) {
if ($first) {
$first = false;
} else {
$query[] = ") OR (";
}
$firstsub = true;
Collaborator
|
Thank you for the pull request. Unfortunately this will not be merged. |
Repository owner
locked and limited conversation to collaborators
Dec 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPDoc improvements
Undefined variable '$value' (see line #1470):
Correct
In most cases using the same variable as a key or value both by the onner and outer 'foreach' loop either is an error or may result in an error in future (see line #1254):
Correct