FIX: missing Model::__unset($property)#106
Closed
qyanu wants to merge 1 commit intoj4mie:developfrom
qyanu:develop
Closed
FIX: missing Model::__unset($property)#106qyanu wants to merge 1 commit intoj4mie:developfrom qyanu:develop
qyanu wants to merge 1 commit intoj4mie:developfrom
qyanu:develop
Conversation
Contributor
Author
|
Better late than never: Observed and followed the guidelines for making a pull request, thus adding a unit-test plus changelog. |
Collaborator
|
Merged in |
Repository owner
locked and limited conversation to collaborators
Dec 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out, that the Model class wasn't defining the __unset method in order to support unset($model->property).
This commit/patch implements __unset by just calling $this->orm->__unset, as is already done for __set, __get and __isset.