* added integration testin g

dlinsin · dlinsin · commit 286ede3c1439 · 2009-11-06T07:10:44.000+01:00
diff --git a/src/main/java/de/linsin/sample/github/rest/domain/Issue.java b/src/main/java/de/linsin/sample/github/rest/domain/Issue.java
@@ -95,9 +95,7 @@ public boolean equals(Object o) {
 
         Issue issue = (Issue) o;
 
-        if (number != issue.number) return false;
-
-        return true;
+        return number == issue.number;
     }
 
     @Override
diff --git a/src/main/java/de/linsin/sample/github/rest/domain/Repository.java b/src/main/java/de/linsin/sample/github/rest/domain/Repository.java
@@ -104,9 +104,7 @@ public boolean equals(Object o) {
 
         Repository that = (Repository) o;
 
-        if (url != null ? !url.equals(that.url) : that.url != null) return false;
-
-        return true;
+        return !(url != null ? !url.equals(that.url) : that.url != null);
     }
 
     @Override
diff --git a/src/main/java/de/linsin/sample/github/rest/service/RepositoryBrowser.java b/src/main/java/de/linsin/sample/github/rest/service/RepositoryBrowser.java
@@ -25,8 +25,9 @@ public class RepositoryBrowser {
      * Browse repositories for a user
      *
      * @param argUsername {@link String} username
-     * @return {@link List} containing {@link Repository} instances, empty List if no repositories are found
-     * @throws {@link NullPointerException} in case passed username is null
+     * @return {@link List} containing {@link Repository} instances, empty List if user exists, but has no repositories
+     * @throws a {@link NullPointerException} in case passed username is null
+     * @throws a {@link HttpClientErrorException} in case the user doesn't exist
      */
     public List<Repository> browse(String argUsername) {
         RestTemplate template = initTemplate();
@@ -43,8 +44,9 @@ public List<Repository> browse(String argUsername) {
      *
      * @param argUsername {@link String} username
      * @param argRepositoryname {@link String} name of repository
-     * @return {@link Repository} instance denoted by passed user and repository name, null if no repository was found
-     * @throws {@link NullPointerException} in case passed username or repository name is null
+     * @return {@link Repository} instance denoted by passed user and repository name
+     * @throws a {@link NullPointerException} in case passed username or repository name is null
+     * @throws a {@link HttpClientErrorException} in case passed user or repository doesn't exist 
      */
     public Repository browse(String argUsername, String argRepositoryname) {
         RestTemplate template = initTemplate();
diff --git a/src/test/java/de/linsin/sample/github/rest/service/RepositoryBrowserIntegrationTest.java b/src/test/java/de/linsin/sample/github/rest/service/RepositoryBrowserIntegrationTest.java
@@ -0,0 +1,63 @@
+package de.linsin.sample.github.rest.service;
+
+import java.util.List;
+
+import de.linsin.sample.github.rest.domain.Repository;
+import static org.junit.Assert.*;
+import org.junit.Before;
+import org.junit.Test;
+import org.springframework.web.client.HttpClientErrorException;
+
+/**
+ * Testing {@link RepositoryBrowserIntegration}
+ *
+ * @author David Linsin - linsin@synyx.de
+ */
+public class RepositoryBrowserIntegrationTest {
+    private RepositoryBrowser classUnderTest;
+    private String username;
+    private String repoName;
+
+    @Before
+    public void setUp() {
+        username = "dlinsin";
+        repoName = "area51";
+        classUnderTest = new RepositoryBrowser();
+    }
+
+    @Test
+    public void browse_repos() {
+        List<Repository> repositoryList = classUnderTest.browse(username);
+        assertFalse(repositoryList.isEmpty());
+        assertEquals(repoName, repositoryList.get(0).getName());
+        assertEquals(username, repositoryList.get(0).getOwner());
+    }
+
+    @Test
+    public void browse_repo() {
+        Repository repository = classUnderTest.browse(username, repoName);
+        assertNotNull(repository);
+        assertEquals(repoName, repository.getName());
+        assertEquals(username, repository.getOwner());
+    }
+
+    @Test(expected = HttpClientErrorException.class)
+    public void browse_user_not_found() {
+        classUnderTest.browse("dlinsin34323");
+    }
+
+    @Test(expected = HttpClientErrorException.class)
+    public void browse_repo_user_nothing_found() {
+        classUnderTest.browse("dlinsin2342", "no_way");
+    }
+
+    @Test(expected = NullPointerException.class)
+    public void browse_repos_passed_null() {
+        classUnderTest.browse(null);
+    }
+
+    @Test(expected = NullPointerException.class)
+    public void browse_repo_passed_null() {
+        classUnderTest.browse(null, repoName);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -95,9 +95,7 @@ public boolean equals(Object o) {`
`95`	`95`
`96`	`96`	`Issue issue = (Issue) o;`
`97`	`97`
`98`		`- if (number != issue.number) return false;`
`99`		`-`
`100`		`- return true;`
	`98`	`+ return number == issue.number;`
`101`	`99`	`}`
`102`	`100`
`103`	`101`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,7 @@ public boolean equals(Object o) {`
`104`	`104`
`105`	`105`	`Repository that = (Repository) o;`
`106`	`106`
`107`		`- if (url != null ? !url.equals(that.url) : that.url != null) return false;`
`108`		`-`
`109`		`- return true;`
	`107`	`+ return !(url != null ? !url.equals(that.url) : that.url != null);`
`110`	`108`	`}`
`111`	`109`
`112`	`110`	`@Override`