BAEL-4447 Enable logging for Apache HttpClient

polomos · polomos · commit 0a7a6e88c44e · 2021-06-20T21:01:03.000+02:00
diff --git a/httpclient-2/pom.xml b/httpclient-2/pom.xml
@@ -26,6 +26,11 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <dependency>
+            <groupId>org.apache.httpcomponents.client5</groupId>
+            <artifactId>httpclient5</artifactId>
+            <version>${httpclient5.version}</version>
+        </dependency>
         <!-- rest template -->
         <dependency>
             <groupId>org.springframework.boot</groupId>
@@ -63,6 +68,7 @@
 
     <properties>
         <httpclient.version>4.5.8</httpclient.version>
+        <httpclient5.version>5.1</httpclient5.version>
         <maven.compiler.source.version>11</maven.compiler.source.version>
         <maven.compiler.target.version>11</maven.compiler.target.version>
         <spring-boot.version>2.1.7.RELEASE</spring-boot.version>
diff --git a/httpclient-2/src/test/java/com/baeldung/httpclient/readresponsebodystring/ApacheHttpClient5UnitTest.java b/httpclient-2/src/test/java/com/baeldung/httpclient/readresponsebodystring/ApacheHttpClient5UnitTest.java
@@ -0,0 +1,29 @@
+package com.baeldung.httpclient.readresponsebodystring;
+
+import org.apache.hc.client5.http.classic.methods.HttpGet;
+import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
+import org.apache.hc.client5.http.impl.classic.CloseableHttpResponse;
+import org.apache.hc.client5.http.impl.classic.HttpClients;
+import org.apache.hc.core5.http.HttpEntity;
+import org.apache.hc.core5.http.ParseException;
+import org.apache.hc.core5.http.io.entity.EntityUtils;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+public class ApacheHttpClient5UnitTest {
+    private final Logger logger = LoggerFactory.getLogger(this.getClass());
+    public static final String DUMMY_URL = "https://postman-echo.com/get";
+
+    @Test
+    public void whenUseApacheHttpClient_thenCorrect() throws IOException, ParseException {
+        HttpGet request = new HttpGet(DUMMY_URL);
+
+        try (CloseableHttpClient client = HttpClients.createDefault(); CloseableHttpResponse response = client.execute(request)) {
+            HttpEntity entity = response.getEntity();
+            logger.debug("Response -> {}", EntityUtils.toString(entity));
+        }
+    }
+}
diff --git a/httpclient-2/src/test/java/com/baeldung/httpclient/readresponsebodystring/ApacheHttpClientUnitTest.java b/httpclient-2/src/test/java/com/baeldung/httpclient/readresponsebodystring/ApacheHttpClientUnitTest.java
@@ -7,10 +7,13 @@
 import org.apache.http.impl.client.HttpClients;
 import org.apache.http.util.EntityUtils;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 
 public class ApacheHttpClientUnitTest {
+    private final Logger logger = LoggerFactory.getLogger(this.getClass());
     public static final String DUMMY_URL = "https://postman-echo.com/get";
 
     @Test
@@ -19,8 +22,7 @@ public void whenUseApacheHttpClient_thenCorrect() throws IOException {
 
         try (CloseableHttpClient client = HttpClients.createDefault(); CloseableHttpResponse response = client.execute(request)) {
             HttpEntity entity = response.getEntity();
-            String result = EntityUtils.toString(entity);
-            System.out.println("Response -> " + result);
+            logger.debug("Response -> {}",  EntityUtils.toString(entity));
         }
     }
 }
diff --git a/httpclient-2/src/test/resources/logback.xml b/httpclient-2/src/test/resources/logback.xml
@@ -0,0 +1,15 @@
+<configuration debug="false">
+    <appender name="stdout" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%date [%level] %logger - %msg %n</pattern>
+        </encoder>
+    </appender>
+
+    <logger name="com.baeldung.httpclient.readresponsebodystring" level="debug"/>
+    <logger name="org.apache.http" level="debug"/>
+    <logger name="org.apache.hc.client5.http" level="debug"/>
+
+    <root level="WARN">
+        <appender-ref ref="stdout"/>
+    </root>
+</configuration>

Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,13 @@`
`7`	`7`	`import org.apache.http.impl.client.HttpClients;`
`8`	`8`	`import org.apache.http.util.EntityUtils;`
`9`	`9`	`import org.junit.Test;`
	`10`	`+import org.slf4j.Logger;`
	`11`	`+import org.slf4j.LoggerFactory;`
`10`	`12`
`11`	`13`	`import java.io.IOException;`
`12`	`14`
`13`	`15`	`public class ApacheHttpClientUnitTest {`
	`16`	`+ private final Logger logger = LoggerFactory.getLogger(this.getClass());`
`14`	`17`	`public static final String DUMMY_URL = "https://postman-echo.com/get";`
`15`	`18`
`16`	`19`	`@Test`
`@@ -19,8 +22,7 @@ public void whenUseApacheHttpClient_thenCorrect() throws IOException {`
`19`	`22`
`20`	`23`	`try (CloseableHttpClient client = HttpClients.createDefault(); CloseableHttpResponse response = client.execute(request)) {`
`21`	`24`	`HttpEntity entity = response.getEntity();`
`22`		`- String result = EntityUtils.toString(entity);`
`23`		`- System.out.println("Response -> " + result);`
	`25`	`+ logger.debug("Response -> {}", EntityUtils.toString(entity));`
`24`	`26`	`}`
`25`	`27`	`}`
`26`	`28`	`}`