Skip to content

Commit 6212a60

Browse files
josephperrottAndrewKushnir
authored andcommitted
build: remove test-ivy-aot yarn script (angular#43862)
Since building with ViewEngine is not longer desired on CI, removing the ivy vs non-ivy testing yarn scripts is done, informing developers to instead use `yarn test` as all tests should be run using the Ivy complier. PR Close angular#43862
1 parent 00d8011 commit 6212a60

3 files changed

Lines changed: 12 additions & 14 deletions

File tree

docs/DEVELOPER.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,8 @@ Bazel is used as the primary tool for building and testing Angular. Building and
7878
incremental with Bazel, and it's possible to only run tests for an individual package instead
7979
of for all packages. Read more about this in the [BAZEL.md](./BAZEL.md) document.
8080

81-
You should execute all test suites before submitting a PR to GitHub. Note that not all tests
82-
support both Ivy and View Engine, so they need to be run separately:
83-
- `yarn test-ivy-aot //packages/...`
84-
- `yarn test-non-ivy //packages/...`
81+
You should execute all test suites before submitting a PR to GitHub.
82+
- `yarn test //packages/...`
8583

8684
**Note**: The first test run will be much slower than future runs. This is because future runs will
8785
benefit from Bazel's capability to do incremental builds.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
"/ ": "",
2525
"postinstall": "node scripts/webdriver-manager-update.js && node --preserve-symlinks --preserve-symlinks-main ./tools/postinstall-patches.js",
2626
"prepare": "husky install",
27-
"test-ivy-aot": "bazelisk test --config=ivy --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot",
28-
"test-non-ivy": "bazelisk test --build_tag_filters=-ivy-only --test_tag_filters=-ivy-only",
27+
"test": "bazelisk test --build_tag_filters=-no-ivy-aot --test_tag_filters=-no-ivy-aot",
28+
"test-view-engine-only": "bazelisk test --config=view-engine --build_tag_filters=no-ivy-aot --test_tag_filters=no-ivy-aot",
29+
"test-ivy-aot": "echo \\`test-ivy-aot\\` no longer valid, use \\`yarn test\\` instead",
30+
"test-non-ivy": "echo \\`test-ivy-aot\\` no longer valid, use \\`yarn test-view-engine-only\\` instead",
2931
"test-tsec": "bazelisk test //... --build_tag_filters=tsec --test_tag_filters=tsec",
30-
"test-fixme-ivy-aot": "bazelisk test --config=ivy --build_tag_filters=-no-ivy-aot --test_tag_filters=-no-ivy-aot",
31-
"list-fixme-ivy-targets": "bazelisk query --output=label 'attr(\"tags\", \"\\[.*fixme-ivy.*\\]\", //...) except kind(\"sh_binary\", //...) except kind(\"devmode_js_sources\", //...)' | sort",
3232
"lint": "yarn -s tslint && yarn -s ng-dev format changed --check",
3333
"tslint": "tslint -c tslint.json --project tsconfig-tslint.json",
3434
"public-api:check": "node goldens/public-api/manage.js test",

packages/compiler-cli/test/compliance/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,15 +154,15 @@ Note:
154154
The simplest way to run all the compliance tests is:
155155

156156
```sh
157-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/...
157+
yarn test //packages/compiler-cli/test/compliance/...
158158
```
159159

160160
If you only want to run one of the three types of test you can be more specific:
161161

162162
```sh
163-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/full
164-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/linked
165-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/test_cases/...
163+
yarn test //packages/compiler-cli/test/compliance/full
164+
yarn test //packages/compiler-cli/test/compliance/linked
165+
yarn test //packages/compiler-cli/test/compliance/test_cases/...
166166
```
167167

168168
(The last command runs the partial compilation tests.)
@@ -201,8 +201,8 @@ to the Bazel test command.
201201
For example:
202202

203203
```sg
204-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/full --config=debug
205-
yarn test-ivy-aot //packages/compiler-cli/test/compliance/linked --config=debug
204+
yarn test //packages/compiler-cli/test/compliance/full --config=debug
205+
yarn test //packages/compiler-cli/test/compliance/linked --config=debug
206206
```
207207

208208
To debug generating the partial golden output use the following form of Bazel command:

0 commit comments

Comments
 (0)