refactor(compiler-cli): avoid naming conflict with built-in global variable (angular#54333)

crisbeto · thePunderWoman · commit 9c2bad9e5e61 · 2024-02-08T14:59:54.000Z
The import of `module` can conflict with the native global variable called `module` and can break some internal tests. These switch to only importing the function we need. PR Close angular#54333
diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts b/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts
@@ -7,7 +7,7 @@
  */
 /// <reference types="node" />
 import fs from 'fs';
-import module from 'module';
+import {createRequire} from 'module';
 import * as p from 'path';
 import {fileURLToPath} from 'url';
 
@@ -96,7 +96,7 @@ export class NodeJSReadonlyFileSystem extends NodeJSPathManipulation implements
   }
   getDefaultLibLocation(): AbsoluteFsPath {
     // G3-ESM-MARKER: G3 uses CommonJS, but externally everything in ESM.
-    const requireFn = isCommonJS ? require : module.createRequire(currentFileUrl!);
+    const requireFn = isCommonJS ? require : createRequire(currentFileUrl!);
     return this.resolve(requireFn.resolve('typescript'), '..');
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*/`
`8`	`8`	`/// <reference types="node" />`
`9`	`9`	`import fs from 'fs';`
`10`		`-import module from 'module';`
	`10`	`+import {createRequire} from 'module';`
`11`	`11`	`import * as p from 'path';`
`12`	`12`	`import {fileURLToPath} from 'url';`
`13`	`13`
`@@ -96,7 +96,7 @@ export class NodeJSReadonlyFileSystem extends NodeJSPathManipulation implements`
`96`	`96`	`}`
`97`	`97`	`getDefaultLibLocation(): AbsoluteFsPath {`
`98`	`98`	`// G3-ESM-MARKER: G3 uses CommonJS, but externally everything in ESM.`
`99`		`- const requireFn = isCommonJS ? require : module.createRequire(currentFileUrl!);`
	`99`	`+ const requireFn = isCommonJS ? require : createRequire(currentFileUrl!);`
`100`	`100`	`return this.resolve(requireFn.resolve('typescript'), '..');`
`101`	`101`	`}`
`102`	`102`	`}`