Skip to content

Commit aadfad7

Browse files
alxhubthePunderWoman
alxhub
authored and
thePunderWoman
committed
build: remove view engine build infrastructure (angular#43884)
This commit removes --config=viewengine and makes Ivy the default for building Angular. PR Close angular#43884
1 parent bb9ff60 commit aadfad7

13 files changed

Lines changed: 21 additions & 258 deletions

File tree

‎.bazelrc‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,6 @@ test --test_output=errors
8181
build --deleted_packages=integration/bazel,integration/bazel/src,integration/bazel/src/hello-world,integration/bazel/test,integration/bazel/tools,integration/bazel/test/e2e
8282
query --deleted_packages=integration/bazel,integration/bazel/src,integration/bazel/src/hello-world,integration/bazel/test,integration/bazel/tools,integration/bazel/test/e2e
8383

84-
################################
85-
# Temporary Settings for Ivy #
86-
################################
87-
# Set the default compiler used for bazel builds to be Ivy.
88-
build --define=angular_ivy_enabled=True
89-
90-
build:view-engine --define=angular_ivy_enabled=False
91-
build:ivy --define=angular_ivy_enabled=True
92-
9384
##################################
9485
# Remote Build Execution support #
9586
# Turn on these settings with #

‎docs/BAZEL.md‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,8 @@ keeps the outputs up-to-date as you save sources.
5959

6060
If you're experiencing problems with seemingly unrelated tests failing, it may be because you're not using the proper flags with your Bazel test runs in Angular.
6161

62-
See also: [`//.bazelrc`](https://github.com/angular/angular/blob/master/.bazelrc) where `--define=angular_ivy_enabled=False` is defined as default.
63-
6462
- `--config=debug`: build and launch in debug mode (see [debugging](#debugging) instructions below)
6563
- `--test_arg=--node_options=--inspect=9228`: change the inspector port.
66-
- `--config=view-engine` Enables ViewEngine mode if present, otherwise Ivy is used. This switches which compiler is used (ngc or ngtsc)
6764
- `--test_tag_filters=<tag>`: filter tests down to tags defined in the `tag` config of your rules in any given `BUILD.bazel`.
6865

6966

@@ -81,7 +78,7 @@ For additional info and testing options, see the
8178
[nodejs_test documentation](https://bazelbuild.github.io/rules_nodejs/Built-ins.html#nodejs_test).
8279

8380
- Click on "Resume script execution" to let the code run until the first `debugger` statement or a previously set breakpoint.
84-
- If you're debugging an ivy test and you want to inspect the generated template instructions, find the template of your component in the call stack and click on `(source mapped from [CompName].js)` at the bottom of the code. You can also disable sourcemaps in the options or go to sources and look into ng:// namespace to see all the generated code.
81+
- If you're debugging a test and you want to inspect the generated template instructions, find the template of your component in the call stack and click on `(source mapped from [CompName].js)` at the bottom of the code. You can also disable sourcemaps in the options or go to sources and look into ng:// namespace to see all the generated code.
8582

8683
### Debugging a Node Test in VSCode
8784

‎integration/bazel/.bazelrc‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ test --test_output=errors
1212
build --local_ram_resources=14336
1313
build --local_cpu_resources=8
1414

15-
# Use the Angular Ivy compiler
16-
# See https://github.com/angular/angular/blob/master/docs/BAZEL.md#various-flags-used-for-tests
17-
build --define=angular_ivy_enabled=True
18-
1915
# Temporary define while angular depends on the legacy rollup_bundle rule.
2016
# TODO: remove this setting after https://github.com/angular/angular/pull/33201 lands.
2117
build --define=enable_legacy_rollup_rule=1

‎packages/bazel/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
"bazelBin": {
1818
"ngc-wrapped": {
1919
"additionalAttributes": {
20-
"configuration_env_vars": "[\"angular_ivy_enabled\"]",
2120
"templated_args": "[\"--bazel_patch_module_resolver\"]"
2221
}
2322
}
@@ -51,4 +50,4 @@
5150
"ng-update": {
5251
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
5352
}
54-
}
53+
}

0 commit comments

Comments
 (0)