Skip to content

Volumes API#55

Merged
jeevatkm merged 4 commits intojeevatkm:masterfrom
strokine:feature/volumes
Aug 4, 2016
Merged

Volumes API#55
jeevatkm merged 4 commits intojeevatkm:masterfrom
strokine:feature/volumes

Conversation

@strokine
Copy link
Copy Markdown
Contributor

@strokine strokine commented Aug 3, 2016

Adding support for Volumes API.

@jeevatkm jeevatkm self-assigned this Aug 3, 2016
@jeevatkm jeevatkm added this to the v2.7 milestone Aug 3, 2016
@jeevatkm
Copy link
Copy Markdown
Owner

jeevatkm commented Aug 3, 2016

@strokine nice (#54), thanks for PR. I will have a look and get back to you.

@strokine
Copy link
Copy Markdown
Contributor Author

strokine commented Aug 4, 2016

Committed code for Volume Actions as well.

@strokine
Copy link
Copy Markdown
Contributor Author

strokine commented Aug 4, 2016

Completed all Block Storage API.

@Override
public Volume createVolume(Volume volume) throws DigitalOceanException, RequestUnsuccessfulException {
if (null == volume
|| StringUtils.isEmpty(volume.getName())
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to StringUtils.isBlank().

@jeevatkm
Copy link
Copy Markdown
Owner

jeevatkm commented Aug 4, 2016

@strokine Thanks for complete implementation. I have added a notes, please take care.

Also, I couldn't see any integration tests, could you please add it here?

@jeevatkm
Copy link
Copy Markdown
Owner

jeevatkm commented Aug 4, 2016

I forget to mention. Please apply Google Java Code Formatter, XML link is at contributing section.

PS: While applying code formatting in enum class, kindly select non-enum code lines and apply it otherwise it will spoil the enum alignments.

@strokine
Copy link
Copy Markdown
Contributor Author

strokine commented Aug 4, 2016

Hey @jeevatkm , I've refactored the code as you suggested and added integration tests.
Before you run the IntTests you have to create 2 volumes, and provide ID from one, and Name from another. This way the IntTests should run better.

RE: Google Java Code Formatter, I don't have it set up on my machine, maybe you could just apply it yourself, or as an option you could use this plugin here? https://github.com/revelc/formatter-maven-plugin

Thanks for the library.
Eugene

@jeevatkm
Copy link
Copy Markdown
Owner

jeevatkm commented Aug 4, 2016

@strokine Thanks again for PR.

I will take care -

  • Code formatting
  • sizeGigabytes -> size
  • Javadoc
  • Enum for volume and volume action

@jeevatkm jeevatkm merged commit 72276cc into jeevatkm:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants