Skip to content

Commit 589952a

Browse files
PierrickVouletpierrick
PierrickVoulet
and
pierrick
authored
Fix inconsistent region tags (googleads#401)
* Added minimal Dockerfile for google-ads-ft Change-Id: Ie4cee5df4f983e08809caa76f5723e426e6d1df3 * Remove dockerfile Change-Id: I6f24ce3faff19cba47ca22f5a28484a551a60d69 * Fix region tag names inconsistencies Change-Id: Ic2a830bd0f7a6fe227a05695749326c2de191612 * Refine region tag to highlight ad creation Change-Id: I8b68abae71d0a12a88a08383dad5ca4e2c1f817b Co-authored-by: pierrick <[email protected]>
1 parent 6c242d3 commit 589952a

File tree

6 files changed

+28
-28
lines changed

6 files changed

+28
-28
lines changed

‎examples/account_management/get_change_summary.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
_DEFAULT_PAGE_SIZE = 1000
2828

2929

30-
# [START get_account_changes]
30+
# [START get_change_summary]
3131
def main(client, customer_id):
3232
ads_service = client.get_service("GoogleAdsService")
3333

@@ -79,7 +79,7 @@ def main(client, customer_id):
7979
f"'{resource_type}' with resource name '{resource_name}' was "
8080
f"{resource_status}"
8181
)
82-
# [END get_account_changes]
82+
# [END get_change_summary]
8383

8484

8585
if __name__ == "__main__":

‎examples/advanced_operations/add_smart_display_ad.py‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def main(
123123
)
124124

125125

126-
# [START add_smart_display_ad_3]
126+
# [START add_smart_display_ad]
127127
def _create_budget(client, customer_id):
128128
campaign_budget_operation = client.get_type("CampaignBudgetOperation")
129129
campaign_budget = campaign_budget_operation.create
@@ -145,10 +145,10 @@ def _create_budget(client, customer_id):
145145
_handle_googleads_exception(ex)
146146

147147
return campaign_budget_response.results[0].resource_name
148-
# [END add_smart_display_ad_3]
148+
# [END add_smart_display_ad]
149149

150150

151-
# [START add_smart_display_ad_4]
151+
# [START add_smart_display_ad_1]
152152
def _create_smart_display_campaign(client, customer_id, budget_resource_name):
153153
campaign_service = client.get_service("CampaignService")
154154
campaign_operation = client.get_type("CampaignOperation")
@@ -185,10 +185,10 @@ def _create_smart_display_campaign(client, customer_id, budget_resource_name):
185185
_handle_googleads_exception(ex)
186186

187187
return campaign_response.results[0].resource_name
188-
# [END add_smart_display_ad_4]
188+
# [END add_smart_display_ad_1]
189189

190190

191-
# [START add_smart_display_ad]
191+
# [START add_smart_display_ad_4]
192192
def _create_ad_group(client, customer_id, campaign_resource_name):
193193
ad_group_service = client.get_service("AdGroupService")
194194
ad_group_operation = client.get_type("AdGroupOperation")
@@ -206,10 +206,10 @@ def _create_ad_group(client, customer_id, campaign_resource_name):
206206
_handle_googleads_exception(ex)
207207

208208
return ad_group_response.results[0].resource_name
209-
# [END add_smart_display_ad]
209+
# [END add_smart_display_ad_4]
210210

211211

212-
# [START add_smart_display_ad_2]
212+
# [START add_smart_display_ad_3]
213213
def _upload_image_asset(
214214
client, customer_id, image_url, image_width, image_height
215215
):
@@ -250,10 +250,10 @@ def _upload_image_asset(
250250
return mutate_asset_response.results[0].asset.id
251251
except GoogleAdsException as ex:
252252
_handle_googleads_exception(ex)
253-
# [END add_smart_display_ad_2]
253+
# [END add_smart_display_ad_3]
254254

255255

256-
# [START add_smart_display_ad_1]
256+
# [START add_smart_display_ad_2]
257257
def _create_responsive_display_ad(
258258
client,
259259
customer_id,
@@ -320,7 +320,7 @@ def _create_responsive_display_ad(
320320
_handle_googleads_exception(ex)
321321

322322
return ad_group_ad_response.results[0].resource_name
323-
# [END add_smart_display_ad_1]
323+
# [END add_smart_display_ad_2]
324324

325325

326326
def _handle_googleads_exception(exception):

‎examples/basic_operations/add_campaigns.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def main(client, customer_id):
3434
campaign_budget_service = client.get_service("CampaignBudgetService")
3535
campaign_service = client.get_service("CampaignService")
3636

37-
# [START add_campaigns_1]
37+
# [START add_campaigns]
3838
# Create a budget, which can be shared by multiple campaigns.
3939
campaign_budget_operation = client.get_type("CampaignBudgetOperation")
4040
campaign_budget = campaign_budget_operation.create
@@ -53,9 +53,9 @@ def main(client, customer_id):
5353
)
5454
except GoogleAdsException as ex:
5555
_handle_googleads_exception(ex)
56-
# [END add_campaigns_1]
56+
# [END add_campaigns]
5757

58-
# [START add_campaigns]
58+
# [START add_campaigns_1]
5959
# Create campaign.
6060
campaign_operation = client.get_type("CampaignOperation")
6161
campaign = campaign_operation.create
@@ -80,7 +80,7 @@ def main(client, customer_id):
8080
campaign.network_settings.target_search_network = True
8181
campaign.network_settings.target_content_network = False
8282
campaign.network_settings.target_partner_search_network = False
83-
# [END add_campaigns]
83+
# [END add_campaigns_1]
8484

8585
# Optional: Set the start date.
8686
start_time = datetime.date.today() + datetime.timedelta(days=1)

‎examples/hotel_ads/add_hotel_ad.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def _add_budget(client, customer_id):
7373
return budget_resource_name
7474

7575

76-
# [START add_hotel_ad_1]
76+
# [START add_hotel_ad_3]
7777
def _add_hotel_ad(client, customer_id, ad_group_resource_name):
7878
ad_group_ad_service = client.get_service("AdGroupAdService")
7979

@@ -99,7 +99,7 @@ def _add_hotel_ad(client, customer_id, ad_group_resource_name):
9999
print(f"Created hotel ad with resource name '{ad_group_ad_resource_name}'.")
100100

101101
return ad_group_resource_name
102-
# [END add_hotel_ad_1]
102+
# [END add_hotel_ad_3]
103103

104104

105105
# [START add_hotel_ad_2]
@@ -131,7 +131,7 @@ def _add_hotel_ad_group(client, customer_id, campaign_resource_name):
131131
# [END add_hotel_ad_2]
132132

133133

134-
# [START add_hotel_ad_3]
134+
# [START add_hotel_ad]
135135
def _add_hotel_campaign(
136136
client,
137137
customer_id,
@@ -141,7 +141,7 @@ def _add_hotel_campaign(
141141
):
142142
campaign_service = client.get_service("CampaignService")
143143

144-
# [START add_hotel_ad]
144+
# [START add_hotel_ad_1]
145145
# Create campaign.
146146
campaign_operation = client.get_type("CampaignOperation")
147147
campaign = campaign_operation.create
@@ -171,7 +171,7 @@ def _add_hotel_campaign(
171171
# Set the campaign network options. Only Google Search is allowed for hotel
172172
# campaigns.
173173
campaign.network_settings.target_google_search = True
174-
# [END add_hotel_ad]
174+
# [END add_hotel_ad_1]
175175

176176
# Add the campaign.
177177
campaign_response = campaign_service.mutate_campaigns(
@@ -185,7 +185,7 @@ def _add_hotel_campaign(
185185
)
186186

187187
return campaign_resource_name
188-
# [END add_hotel_ad_3]
188+
# [END add_hotel_ad]
189189

190190

191191
if __name__ == "__main__":

‎examples/remarketing/add_merchant_center_dynamic_remarketing_campaign.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
from google.ads.googleads.errors import GoogleAdsException
2929

3030

31-
# [START add_merchant_center_dynamic_remarketing_campaign]
3231
def main(
3332
client,
3433
customer_id,
@@ -145,6 +144,7 @@ def _create_ad_group(client, customer_id, campaign_resource_name):
145144
return ad_group_resource_name
146145

147146

147+
# [START add_merchant_center_dynamic_remarketing_campaign]
148148
def _create_ad(client, customer_id, ad_group_resource_name):
149149
"""Creates the responsive display ad.
150150
@@ -219,6 +219,7 @@ def _create_ad(client, customer_id, ad_group_resource_name):
219219
"Created ad group ad with resource name "
220220
f"'{ad_group_ad_response.results[0].resource_name}'."
221221
)
222+
# [END add_merchant_center_dynamic_remarketing_campaign]
222223

223224

224225
def _upload_image_asset(client, customer_id, image_url, asset_name):
@@ -290,7 +291,6 @@ def _attach_user_list(
290291
"Created ad group criterion with resource name "
291292
f"'{ad_group_criterion_response.results[0].resource_name}'."
292293
)
293-
# [END add_merchant_center_dynamic_remarketing_campaign]
294294

295295

296296
if __name__ == "__main__":

‎examples/remarketing/add_remarketing_action.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def main(client, customer_id, page_size):
4141
_print_remarketing_action_attributes(queried_remarketing_action)
4242

4343

44-
# [START add_remarketing_action_1]
44+
# [START add_remarketing_action]
4545
def _add_remarketing_action(client, customer_id):
4646
remarketing_action_service = client.get_service("RemarketingActionService")
4747
remarketing_action_operation = client.get_type("RemarketingActionOperation")
@@ -69,7 +69,7 @@ def _add_remarketing_action(client, customer_id):
6969
sys.exit(1)
7070

7171
return remarketing_action_response.results[0].resource_name
72-
# [END add_remarketing_action_1]
72+
# [END add_remarketing_action]
7373

7474

7575
def _query_remarketing_action(client, customer_id, resource_name, page_size):
@@ -84,15 +84,15 @@ def _query_remarketing_action(client, customer_id, resource_name, page_size):
8484
Returns:
8585
the found remarketing action
8686
"""
87-
# [START add_remarketing_action]
87+
# [START add_remarketing_action_1]
8888
query = f"""
8989
SELECT
9090
remarketing_action.id,
9191
remarketing_action.name,
9292
remarketing_action.tag_snippets
9393
FROM remarketing_action
9494
WHERE remarketing_action.resource_name = '{resource_name}'"""
95-
# [END add_remarketing_action]
95+
# [END add_remarketing_action_1]
9696

9797
googleads_service_client = client.get_service("GoogleAdsService")
9898
search_request = client.get_type("SearchGoogleAdsRequest")

0 commit comments

Comments
 (0)