Ignore the conversion test if running in a non-Mac OS X platform.

gebhardt · gebhardt · commit df4ff8fda2d6 · 2012-10-23T12:55:31.000+02:00
diff --git a/pom.xml b/pom.xml
@@ -88,6 +88,11 @@
         </plugins>
     </build>
     <dependencies>
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-lang3</artifactId>
+            <version>3.1</version>
+        </dependency>
         <dependency>
             <groupId>commons-codec</groupId>
             <artifactId>commons-codec</artifactId>
diff --git a/src/main/java/com/sap/prd/mobile/ios/mios/xcodeprojreader/jaxb/JAXBPlistParser.java b/src/main/java/com/sap/prd/mobile/ios/mios/xcodeprojreader/jaxb/JAXBPlistParser.java
@@ -37,6 +37,7 @@
 import javax.xml.parsers.SAXParserFactory;
 import javax.xml.transform.sax.SAXSource;
 
+import org.apache.commons.lang3.SystemUtils;
 import org.xml.sax.EntityResolver;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXException;
@@ -151,6 +152,10 @@ public void convert(String projectFile, String destinationProjectFile) throws IO
 
   public void convert(File projectFile, File destinationProjectFile) throws IOException
   {
+    if (!SystemUtils.IS_OS_MAC_OSX) {
+      throw new UnsupportedOperationException("The pbxproj file conversion can only be performed on a Mac OS X " +
+            "operating system as the Mac OS X specific tool 'plutil' gets called.");
+    }
     Process exec = Runtime.getRuntime().exec(
           new String[] { "plutil", "-convert", "xml1", "-o", destinationProjectFile.getAbsolutePath(),
               projectFile.getAbsolutePath() });
diff --git a/src/test/java/com/sap/prd/mobile/ios/mios/xcodeprojreader/jaxb/JAXBPlistParserTest.java b/src/test/java/com/sap/prd/mobile/ios/mios/xcodeprojreader/jaxb/JAXBPlistParserTest.java
@@ -20,7 +20,9 @@
 package com.sap.prd.mobile.ios.mios.xcodeprojreader.jaxb;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
 
 import java.io.ByteArrayInputStream;
 import java.io.File;
@@ -34,6 +36,7 @@
 
 import junit.framework.Assert;
 
+import org.apache.commons.lang3.SystemUtils;
 import org.custommonkey.xmlunit.XMLAssert;
 import org.custommonkey.xmlunit.XMLUnit;
 import org.junit.Test;
@@ -93,9 +96,19 @@ public void convertOpenStepToXML() throws Exception
     File xmlProj = File.createTempFile("project", ".pbxproj");
     xmlProj.deleteOnExit();
 
-    parser.convert(fileNameOpenStep, xmlProj.getAbsolutePath());
-    Plist plist = parser.load(xmlProj.getAbsolutePath());
-    assertEquals("1.0", plist.getVersion());
+    try
+    {
+      parser.convert(fileNameOpenStep, xmlProj.getAbsolutePath());
+      Plist plist = parser.load(xmlProj.getAbsolutePath());
+      assertEquals("1.0", plist.getVersion());
+    }
+    catch (UnsupportedOperationException ex)
+    {
+      // If we are running on a non Mac OS X system an UnsupportedOperationException is expected
+      assertFalse("The convert function should only fail on non Mac OS X systems", SystemUtils.IS_OS_MAC_OSX);
+      assertTrue("Wrong UnsupportedOperationException message", ex.getMessage().contains("Mac OS X"));
+    }
+
   }
 
   @Test(expected = javax.xml.bind.UnmarshalException.class)
