Merge pull request dtmilano#182 from steve-the-edwards/master

dtmilano · dtmilano · commit 7659721e933c · 2016-02-18T23:22:00.000-05:00
hasAttr check and Updated README
diff --git a/README.md b/README.md
@@ -1,7 +1,18 @@
 AndroidViewClient
 =================
 <a href="#"><img src="https://github.com/dtmilano/AndroidViewClient/wiki/images/culebra-logo-transparent-204x209-rb-border.png" align="left" hspace="0" vspace="6"></a>
-**AndroidViewClient** is ~~an extension to [monkeyrunner](http://developer.android.com/tools/help/monkeyrunner_concepts.html)~~ a 100% pure python tool that automates or simplifies test script creation providing higher level operations and the ability of obtaining the tree of Views present at any given moment on the device or emulator screen.
+**AndroidViewClient** is a test framework for Android applications that:
+<ul>
+    <li>Automates driving Android applications</li>
+    <li><b>Generates</b> re-usable scripts</li>
+    <li>Provides view-based <i>device independent</i> UI interaction</li>
+    <li>Uses 'logical' screen comparison (UI Automator Hierarchy based) over image comparison (Avoiding extraneous 
+    detail issues, such as time or data changes)</li>
+    <li>Supports running on multiple devices</li>
+    <li>Provides simple control for high level operations like language change and activity start</li>
+    <li>Supports all Android APIs</li>
+    <li>Is written in python</li>
+</ul>
 
 [![Downloads](https://img.shields.io/pypi/dm/androidviewclient.svg)](https://pypi.python.org/pypi/androidviewclient/)
 [![Latest Version](https://img.shields.io/pypi/v/androidviewclient.svg)](https://pypi.python.org/pypi/androidviewclient/)
diff --git a/src/com/dtmilano/android/viewclient.py b/src/com/dtmilano/android/viewclient.py
@@ -2556,7 +2556,7 @@ def __init__(self, device, serialno, adb=None, autodump=True, forceviewserveruse
 
     def __del__(self):
         # should clean up some things
-        if self.uiAutomatorHelper:
+        if hasattr(self, 'uiAutomatorHelper') and self.uiAutomatorHelper:
             if DEBUG or True:
                 print >> sys.stderr, "Stopping UiAutomatorHelper..."
             self.uiAutomatorHelper.quit()
diff --git a/tests/com/dtmilano/android/uiautomator/uiautomatorhelpertests.py b/tests/com/dtmilano/android/uiautomator/uiautomatorhelpertests.py
@@ -61,7 +61,7 @@ def testTakeScreenshot(self):
     def testClick_random(self):
         x = random.randint(0, 1000)
         y = random.randint(0, 1000)
-        response = self.uiAutomatorHelper.click(x, y)
+        response = self.uiAutomatorHelper.click(x=x, y=y)
         if DEBUG:
             print >> sys.stderr, "response=", response
 
