Skip to content

Commit b8ad775

Browse files
authored
Fix bug in upload_offline_conversion example. (googleads#734)
1 parent 1c01c5e commit b8ad775

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

examples/remarketing/upload_offline_conversion.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,10 @@ def main(
6262
gbraid parameters must be None.
6363
"""
6464
click_conversion = client.get_type("ClickConversion")
65+
conversion_upload_service = client.get_service("ConversionUploadService")
6566
conversion_action_service = client.get_service("ConversionActionService")
66-
click_conversion.conversion_action = (
67-
conversion_action_service.conversion_action_path(
68-
customer_id, conversion_action_id
69-
)
67+
click_conversion.conversion_action = conversion_action_service.conversion_action_path(
68+
customer_id, conversion_action_id
7069
)
7170

7271
# Sets the single specified ID field.
@@ -83,21 +82,18 @@ def main(
8382

8483
if conversion_custom_variable_id and conversion_custom_variable_value:
8584
conversion_custom_variable = client.get_type("CustomVariable")
86-
conversion_custom_variable.conversion_custom_variable = (
87-
conversion_custom_variable_id
85+
conversion_custom_variable.conversion_custom_variable = conversion_upload_service.conversion_custom_variable_path(
86+
customer_id, conversion_custom_variable_id
8887
)
8988
conversion_custom_variable.value = conversion_custom_variable_value
9089
click_conversion.custom_variables.append(conversion_custom_variable)
9190

92-
conversion_upload_service = client.get_service("ConversionUploadService")
9391
request = client.get_type("UploadClickConversionsRequest")
9492
request.customer_id = customer_id
9593
request.conversions.append(click_conversion)
9694
request.partial_failure = True
97-
conversion_upload_response = (
98-
conversion_upload_service.upload_click_conversions(
99-
request=request,
100-
)
95+
conversion_upload_response = conversion_upload_service.upload_click_conversions(
96+
request=request,
10197
)
10298
uploaded_click_conversion = conversion_upload_response.results[0]
10399
print(

0 commit comments

Comments
 (0)