introduce hook (original intent was to be able to hook before the apk build (but after build.py rendering) in order to change AndroidManifest.xml)

tito · tito · commit f7aba8a4461e · 2017-01-04T11:18:06.000+01:00
diff --git a/pythonforandroid/toolchain.py b/pythonforandroid/toolchain.py
@@ -8,7 +8,6 @@
 
 from __future__ import print_function
 
-
 def check_python_dependencies():
     # Check if the Python requirements are installed. This appears
     # before the imports because otherwise they're imported elsewhere.
@@ -76,6 +75,7 @@ def check_python_dependencies():
 
 import argparse
 import sh
+import imp
 from appdirs import user_data_dir
 import logging
 
@@ -293,12 +293,17 @@ def __init__(self):
             help=('Dependencies of your app, should be recipe names or '
                   'Python modules'),
             default='')
-        
+
         generic_parser.add_argument(
             '--bootstrap',
             help='The bootstrap to build with. Leave unset to choose automatically.',
             default=None)
 
+        generic_parser.add_argument(
+            '--hook',
+            help='Filename to a module that contain python-for-android hooks',
+            default=None)
+
         add_boolean_option(
             generic_parser, ["force-build"],
             default=False,
@@ -488,6 +493,18 @@ def add_parser(subparsers, *args, **kwargs):
         # Each subparser corresponds to a method
         getattr(self, args.subparser_name.replace('-', '_'))(args)
 
+    def hook(self, name):
+        if not self.args.hook:
+            return
+        if not hasattr(self, "hook_module"):
+            # first time, try to load the hook module
+            self.hook_module = imp.load_source("pythonforandroid.hook", self.args.hook)
+        if hasattr(self.hook_module, name):
+            info("Hook: execute {}".format(name))
+            getattr(self.hook_module, name)(self)
+        else:
+            info("Hook: ignore {}".format(name))
+
     @property
     def default_storage_dir(self):
         udd = user_data_dir('python-for-android')
@@ -691,8 +708,12 @@ def apk(self, args):
 
         build = imp.load_source('build', join(dist.dist_dir, 'build.py'))
         with current_directory(dist.dist_dir):
+            self.hook("before_apk_build")
             build_args = build.parse_args(args.unknown_args)
+            self.hook("after_apk_build")
+            self.hook("before_apk_assemble")
             output = shprint(sh.ant, args.build_mode, _tail=20, _critical=True, _env=env)
+            self.hook("after_apk_assemble")
 
         info_main('# Copying APK to current directory')
 
@@ -807,7 +828,7 @@ def _adb(self, commands):
         for line in output:
             sys.stdout.write(line)
             sys.stdout.flush()
-        
+
 
     def build_status(self, args):
 
