MinGW: disable CRT command line globbing

kblees · kusma · commit bf1a7ff510a4 · 2011-06-21T13:24:09.000+02:00
MingwRT listens to _CRT_glob to decide if __getmainargs should
perform globbing, with the default being that it should.
Unfortunately, __getmainargs globbing is sub-par; for instance
patterns like "*.c" will only match c-sources in the current
directory.

Disable __getmainargs' command line wildcard expansion, so these
patterns will be left untouched, and handled by Git's superior
built-in globbing instead.

MSVC defaults to no globbing, so we don't need to do anything
in that case.

This fixes t5505 and t7810.

Signed-off-by: Karsten Blees &lt;blees@dcon.de&gt;
Signed-off-by: Erik Faye-Lund &lt;kusmabite@gmail.com&gt;
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -1853,6 +1853,12 @@ int mingw_offset_1st_component(const char *path)
 	return offset + is_dir_sep(path[offset]);
 }
 
+/*
+ * Disable MSVCRT command line wildcard expansion (__getmainargs called from
+ * mingw startup code, see init.c in mingw runtime).
+ */
+int _CRT_glob = 0;
+
 void mingw_startup()
 {
 	/* copy executable name to argv[0] */

Original file line number	Diff line number	Diff line change
`@@ -1853,6 +1853,12 @@ int mingw_offset_1st_component(const char *path)`
`1853`	`1853`	`return offset + is_dir_sep(path[offset]);`
`1854`	`1854`	`}`
`1855`	`1855`
	`1856`	`+/*`
	`1857`	`+ * Disable MSVCRT command line wildcard expansion (__getmainargs called from`
	`1858`	`+ * mingw startup code, see init.c in mingw runtime).`
	`1859`	`+ */`
	`1860`	`+int _CRT_glob = 0;`
	`1861`	`+`
`1856`	`1862`	`void mingw_startup()`
`1857`	`1863`	`{`
`1858`	`1864`	`/* copy executable name to argv[0] */`