gitweb: use href() when generating URLs in OPML

Oblomov · gitster · commit df63fbbf46c5 · 2009-01-05T10:45:54.000-08:00
Since the OPML project list view was hand-coding the RSS and HTML URLs,
it didn't respect global options such as use_pathinfo. Make it use
href() to ensure consistency with the rest of the gitweb setup.

Signed-off-by: Giuseppe Bilotta &lt;giuseppe.bilotta@gmail.com&gt;
Acked-by: Jakub Narebski &lt;jnareb@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
@@ -6146,8 +6146,8 @@ sub git_opml {
 		}
 
 		my $path = esc_html(chop_str($proj{'path'}, 25, 5));
-		my $rss  = "$my_url?p=$proj{'path'};a=rss";
-		my $html = "$my_url?p=$proj{'path'};a=summary";
+		my $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);
+		my $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);
 		print "<outline type=\"rss\" text=\"$path\" title=\"$path\" xmlUrl=\"$rss\" htmlUrl=\"$html\"/>\n";
 	}
 	print <<XML;

Original file line number	Diff line number	Diff line change
`@@ -6146,8 +6146,8 @@ sub git_opml {`
`6146`	`6146`	`}`
`6147`	`6147`
`6148`	`6148`	`my $path = esc_html(chop_str($proj{'path'}, 25, 5));`
`6149`		`- my $rss = "$my_url?p=$proj{'path'};a=rss";`
`6150`		`- my $html = "$my_url?p=$proj{'path'};a=summary";`
	`6149`	`+ my $rss = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);`
	`6150`	`+ my $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);`
`6151`	`6151`	`print "<outline type=\"rss\" text=\"$path\" title=\"$path\" xmlUrl=\"$rss\" htmlUrl=\"$html\"/>\n";`
`6152`	`6152`	`}`
`6153`	`6153`	`print <<XML;`