New error handling

sebs · sebs · commit a52cbe79446b · 2018-03-01T14:57:28.000+01:00
diff --git a/lib/init.js b/lib/init.js
@@ -56,12 +56,11 @@ module.exports = function(apiKey, chain) {
         }
 
         if (data.error) {
-          return reject(data.error.message);
+          return reject(new Error(data.error));
         }
-
         resolve(data);
       }).catch(function(error) {
-        return reject(error);
+        return reject(new Error(error));
       });
     });
   }
@@ -544,7 +543,7 @@ module.exports = function(apiKey, chain) {
         let action = 'balance';
         const tag = 'latest';
 
-        if (typeof address != 'string' && address.length) {
+        if (typeof address !== 'string' && address && address.length) {
           address = address.join(',');
           action = 'balancemulti';
         }
diff --git a/test/error-test.js b/test/error-test.js
@@ -0,0 +1,14 @@
+'use strict';
+const assert = require('chai').assert;
+const init = require('../.').init;
+describe('balance', function() {
+
+  it('no param sends a error', function(done){
+    var api = init();
+    var balance = api.account.balance();
+    balance.catch(function(err){
+      assert.ok(err);
+      done();
+    });
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,11 @@ module.exports = function(apiKey, chain) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`if (data.error) {`
`59`		`- return reject(data.error.message);`
	`59`	`+ return reject(new Error(data.error));`
`60`	`60`	`}`
`61`		`-`
`62`	`61`	`resolve(data);`
`63`	`62`	`}).catch(function(error) {`
`64`		`- return reject(error);`
	`63`	`+ return reject(new Error(error));`
`65`	`64`	`});`
`66`	`65`	`});`
`67`	`66`	`}`
`@@ -544,7 +543,7 @@ module.exports = function(apiKey, chain) {`
`544`	`543`	`let action = 'balance';`
`545`	`544`	`const tag = 'latest';`
`546`	`545`
`547`		`- if (typeof address != 'string' && address.length) {`
	`546`	`+ if (typeof address !== 'string' && address && address.length) {`
`548`	`547`	`address = address.join(',');`
`549`	`548`	`action = 'balancemulti';`
`550`	`549`	`}`