Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pydata/xarray
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: kmsquire/xarray
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 10 files changed
  • 3 contributors

Commits on Jul 16, 2021

  1. Allow padding to be turned off for rolling windows 

    * Adds a `pad: bool` parameter to DataArray.rolling / Dataset.rolling
    @kmsquire
    kmsquire committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    039a9bf View commit details
    Browse the repository at this point in the history

  2. Fix iteration on rolling windows to handle no padding 

    Also changes the object returned during iteration, so that it is the same
(modulo transposition) as the view created during rolling_window.construct()
along the rolling axis.
    @kmsquire
    kmsquire committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    90228b0 View commit details
    Browse the repository at this point in the history

  3. Add tests for rolling(..., pad=False)

    @kmsquire
    kmsquire committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    c43db78 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Update xarray/core/rolling.py 

    Co-authored-by: Deepak Cherian <[email protected]>
    @kmsquire @dcherian
    kmsquire and dcherian authored Jul 19, 2021
    Configuration menu
    Copy the full SHA
    30a0b47 View commit details
    Browse the repository at this point in the history

  2. Update xarray/core/rolling.py 

    Co-authored-by: Deepak Cherian <[email protected]>
    @kmsquire @dcherian
    kmsquire and dcherian authored Jul 19, 2021
    Configuration menu
    Copy the full SHA
    0314d2f View commit details
    Browse the repository at this point in the history

  3. Rename _get_rolling_dim_coords -> _get_output_coords

    @kmsquire
    kmsquire committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    18562b8 View commit details
    Browse the repository at this point in the history

  4. Add comment better explaining _get_output_coords

    @kmsquire
    kmsquire committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    90ae11d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Simplify _get_output_coords

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    33ccbf6 View commit details
    Browse the repository at this point in the history

  2. Remove utils.get_slice_offsets (unused)

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5df7b12 View commit details
    Browse the repository at this point in the history

  3. Simplify get_pads

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    174750a View commit details
    Browse the repository at this point in the history

  4. Fix rolling object construction in _count

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    564833a View commit details
    Browse the repository at this point in the history

  5. Skip padding in variable.rolling if not required

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    68b112a View commit details
    Browse the repository at this point in the history

  6. Fix rolling on DataArrays with nonunique dimension coordinates

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    ea332a6 View commit details
    Browse the repository at this point in the history

  7. Rename expand_args_to_num_dims -> expand_args_to_dims

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    ef0ac63 View commit details
    Browse the repository at this point in the history

  8. Update expand_args_to_dims 

    * Generalize type of dim (str -> Hashable)
* Rename to_array -> to_list
* Make error message clearer (only print unexpected inputs)
* Allow lists of length one as inputs
* Add tests
    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    cdadc60 View commit details
    Browse the repository at this point in the history

  9. Update get_pads() types, comments

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a2b235c View commit details
    Browse the repository at this point in the history

  10. Use "length" instead of "count" to refer to the length of a coordinate

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b98ab3a View commit details
    Browse the repository at this point in the history

  11. Update type of _get_output_dim_selector

    @kmsquire
    kmsquire committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b36a049 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Remove need for typing-extensions 3.10 

    * Tensorflow has a conflict
    @kmsquire
    kmsquire committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    25c0016 View commit details
    Browse the repository at this point in the history
Loading