Patch async_session on all router modules in test fixture

kutcode · claude · kutcode · commit b1c3fd88ebfa · 2026-04-02T16:56:45.000-04:00
Background tasks in upload/qa/flagged routers use the module-level
async_session directly (not the FastAPI dependency), so the test
fixture must also patch those references to point at the test DB.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/backend/tests/conftest.py b/backend/tests/conftest.py
@@ -8,6 +8,10 @@
 from sqlalchemy.ext.asyncio import create_async_engine, async_sessionmaker, AsyncSession
 from docx import Document as DocxDocument
 
+import app.database as _db_module
+import app.routers.upload as _upload_module
+import app.routers.qa as _qa_module
+import app.routers.flagged as _flagged_module
 from app.database import Base, get_db
 import app.models  # noqa: F401 — ensure all models are registered with Base.metadata before create_all
 from app.main import app
@@ -64,17 +68,45 @@ async def db_session(db_engine):
 
 
 @pytest_asyncio.fixture
-async def client(db_session):
-    """HTTP test client with overridden DB dependency."""
+async def client(db_engine, db_session):
+    """HTTP test client with overridden DB dependency.
+
+    Patches both the FastAPI dependency *and* the module-level engine/session
+    so that background tasks (which use ``async_session()`` directly) also
+    hit the test database.
+    """
     async def override_get_db():
         yield db_session
 
+    # Patch module-level engine + session factory so background tasks use the test DB
+    test_session_factory = async_sessionmaker(db_engine, class_=AsyncSession, expire_on_commit=False)
+
+    originals = {
+        "db_engine": _db_module.engine,
+        "db_session": _db_module.async_session,
+        "upload_session": _upload_module.async_session,
+        "qa_session": _qa_module.async_session,
+        "flagged_session": _flagged_module.async_session,
+    }
+    _db_module.engine = db_engine
+    _db_module.async_session = test_session_factory
+    _upload_module.async_session = test_session_factory
+    _qa_module.async_session = test_session_factory
+    _flagged_module.async_session = test_session_factory
+
     app.dependency_overrides[get_db] = override_get_db
     transport = ASGITransport(app=app)
     async with AsyncClient(transport=transport, base_url="http://test") as c:
         yield c
     app.dependency_overrides.clear()
 
+    # Restore originals
+    _db_module.engine = originals["db_engine"]
+    _db_module.async_session = originals["db_session"]
+    _upload_module.async_session = originals["upload_session"]
+    _qa_module.async_session = originals["qa_session"]
+    _flagged_module.async_session = originals["flagged_session"]
+
 
 @pytest.fixture
 def make_docx(tmp_path):
