[[ Bug 22382 ]] Account for soft button bar on Android

montegoulding · montegoulding · commit cff286100deb · 2019-11-22T08:28:14.000+11:00
This patch adds a function to calculate the height of the soft button bar on
android and uses it when determining if the keyboard is visible.
diff --git a/docs/notes/bugfix-22382.md b/docs/notes/bugfix-22382.md
@@ -0,0 +1 @@
+# Fix incorrect stack size on Android for fullscreen mode `showAll` when the device has a soft button bar
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -1484,10 +1484,24 @@ boolean keyboardIsVisible()
         int t_screen_height = ((LiveCodeActivity)getContext()).s_main_layout.getRootView().getHeight();
         
         // keyboard height equals (screen height - (user app height + status))
-        int t_keyboard_height = t_screen_height - (t_app_rect.height() + t_status_bar_height);
+        int t_keyboard_height = t_screen_height - (t_app_rect.height() + t_status_bar_height) - getSoftbuttonsbarHeight();
         
         return t_keyboard_height > 0;
     }
+    
+    private int getSoftbuttonsbarHeight() {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN_MR1) {
+            return 0;
+        }
+        
+        DisplayMetrics t_metrics = new DisplayMetrics();
+        getWindowManager().getDefaultDisplay().getMetrics(t_metrics);
+        int t_usable_height = t_metrics.heightPixels;
+        getWindowManager().getDefaultDisplay().getRealMetrics(t_metrics);
+        int t_real_height = t_metrics.heightPixels;
+        
+        return t_real_height > t_usable_height ? t_real_height - t_usable_height : 0;
+    }
 	
 	void updateKeyboardVisible()
 	{

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+# Fix incorrect stack size on Android for fullscreen mode `showAll` when the device has a soft button bar