Auto-merge pull request #7032 from livecodeian/feature-prebuilt-thirdparty-PIC

livecode-vulcan · web-flow · commit b41f12951c3e · 2019-05-13T11:23:49.000+01:00
[[ Prebuilt ]] Ensure linux thirdparty libs are prebuilt with position-independent code

This patch modifies the Linux configuration settings so all static libraries are compiled using the `fPIC` gcc flag. This ensures the thirdparty prebuilt libraries can be used by toolchains that produce position-independent executables by default.
diff --git a/config/linux-settings.gypi b/config/linux-settings.gypi
@@ -29,15 +29,6 @@
 	# need to be compiled with the correct compilation flags
 	'target_conditions':
 	[
-		[
-			'_type' == "executable" or '_type == "loadable_module" or _type == "shared_library" or (_type == "static_library" and library_for_module != 0)',
-			{
-				'cflags':
-				[
-					'-fPIC',
-				],
-			},
-		],
 		[
 			'server_mode == 0',
 			{
@@ -100,6 +91,7 @@
 	
 	'cflags':
 	[
+		'-fPIC',
 		'-fstrict-aliasing',
 		'-fvisibility=hidden',
 	],
diff --git a/prebuilt/versions/thirdparty_buildrevision b/prebuilt/versions/thirdparty_buildrevision
@@ -0,0 +1 @@
+PIC

Original file line number	Diff line number	Diff line change
`@@ -29,15 +29,6 @@`
`29`	`29`	`# need to be compiled with the correct compilation flags`
`30`	`30`	`'target_conditions':`
`31`	`31`	`[`
`32`		`- [`
`33`		`- '_type' == "executable" or '_type == "loadable_module" or _type == "shared_library" or (_type == "static_library" and library_for_module != 0)',`
`34`		`- {`
`35`		`- 'cflags':`
`36`		`- [`
`37`		`- '-fPIC',`
`38`		`- ],`
`39`		`- },`
`40`		`- ],`
`41`	`32`	`[`
`42`	`33`	`'server_mode == 0',`
`43`	`34`	`{`
`@@ -100,6 +91,7 @@`
`100`	`91`
`101`	`92`	`'cflags':`
`102`	`93`	`[`
	`94`	`+ '-fPIC',`
`103`	`95`	`'-fstrict-aliasing',`
`104`	`96`	`'-fvisibility=hidden',`
`105`	`97`	`],`