[22308] Ensure Search for Inclusions works if script is unlocked

livecodepanos · livecodepanos · commit c1ca132f6760 · 2019-09-13T15:28:47.000+03:00
This patch checks if the script if locked before searching for inclusions,
rather than checking if the stack has a password. If the script is locked,
then the auto-search cannot be done and a warning is thrown.
diff --git a/docs/notes/bugfix-22308.md b/docs/notes/bugfix-22308.md
@@ -0,0 +1 @@
+# Ensure "Search for Inclusions" works if the script of a password-protected stack is unlocked 
diff --git a/ide-support/revsblibrary.livecodescript b/ide-support/revsblibrary.livecodescript
@@ -2848,7 +2848,7 @@ private command revSmartChecking pStackFilesList, @xSettings
       repeat for each line tStack in tStacksList
          if tNewSettings["inclusions"] is "search" then
             # OK-2009-09-07 : Value of password and passkey properties changed, the above test no longer works
-            if the password of stack tStack then
+            if __ScriptIsLocked(tStack) then
                revStandaloneAddWarning "Could not auto-detect inclusions or security categories because stack is password protected"
                exit revSmartChecking
             end if
@@ -2875,6 +2875,15 @@ private command revSmartChecking pStackFilesList, @xSettings
    unlock messages
 end revSmartChecking
 
+private function __ScriptIsLocked pStack
+   try
+      get the script of stack pStack
+   catch tError
+      return true
+   end try
+   return false
+end __ScriptIsLocked
+
 private command revCheckObject pObject,pUserLibraries, @xSettings, @xWidgetKinds
    
    if word 1 of pObject is "widget" then

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure "Search for Inclusions" works if the script of a password-protected stack is unlocked`