Add a fake installer to the OSX DMG

livecodefraser · livecodefraser · commit f82fb79ce31f · 2016-02-26T11:02:13.000Z
This installer launches an AppleScript that opens a Finder window
on the DMG so the user can drag it to their Applications folder.

This is needed to that old auto-updaters that try to launch an
installer in the DMG do something useful rather than failing
silently.
diff --git a/builder/tools_builder.livecodescript b/builder/tools_builder.livecodescript
@@ -498,6 +498,20 @@ command toolsBuilderMakeAppBundle pVersion, pEdition, pPlatform
       throw "failure"
    end if
    
+   -- Copy a shell script and AppleScript into the app bundle to catch attempts 
+   -- from old auto-updaters to launch the installer
+   builderLog "message", "Adding installer shim to app bundle"
+   get shell ("install -m755" && escapeArg(builderCommunityResourceFolder() & "/dmg/fake-installer.sh") && escapeArg(tAppBundle & "/Contents/MacOS/installer"))
+   if the result is not zero then
+      builderLog "error", "Failed to copy installer stub shell script:" && it
+      throw "failure"
+   end if
+   get shell ("osacompile" && "-o" && escapeArg(tAppBundle & "/Contents/MacOS/installer.scpt") && escapeArg(builderCommunityResourceFolder() & "/dmg/open-dmg.applescript"))
+   if the result is not zero then
+      builderLog "error", "Failed to compile installer stub AppleScript:" && it
+      throw "failure"
+   end if
+   
    -- Find the signing identity and sign the app bundle
    get findSigningIdentity()
    if it is not empty then
diff --git a/engine/rsrc/dmg/fake-installer.sh b/engine/rsrc/dmg/fake-installer.sh
@@ -0,0 +1,23 @@
+#!/bin/bash
+#
+# This script is used to provide a bridge for old LiveCode auto-updaters that
+# expect the LiveCode update DMG to contain an installer rather than the app
+# bundle that is now is. It fires off an AppleScript that opens a Finder
+# window on the DMG so that the user can drag the app bundle to their
+# Applications folder.
+
+# Location of this script file
+# <something>.app/Contents/MacOS/installer
+self=${BASH_SOURCE[0]}
+selfdir=$(dirname "${self}")
+
+# Location of the AppleScript
+# <something>.app/Contents/MacOS/installer.scpt
+script="${selfdir}"/installer.scpt
+
+# Directory to open in Finder
+# AppleScript can only deal with absolute paths and doesn't like '..'
+target=$(cd "${selfdir}/../../.." && pwd)
+
+osascript "${script}" "${target}"
+exit $?
diff --git a/engine/rsrc/dmg/open-dmg.applescript b/engine/rsrc/dmg/open-dmg.applescript
@@ -0,0 +1,17 @@
+on run argv
+	if the number of items of argv is not 1 then
+		return "Error: invalid parameters"
+	end if
+	
+	set folderPath to POSIX file (item 1 of argv)
+	
+	tell application "Finder"
+		tell folder folderPath
+			-- Open a Finder window on the DMG
+			open
+			
+			-- Bring that window to the front
+			activate
+		end tell
+	end tell
+end run
