Merge pull request livecode#1285 from runrevsebastien/bugfix-view_rect

livecodesebastien · livecodesebastien · commit 1835a22741f8 · 2014-10-16T08:52:56.000+01:00
[[ ViewRect ]] Ensure that the view_rect is copied when a stack is copie...
diff --git a/engine/src/stackview.cpp b/engine/src/stackview.cpp
@@ -127,6 +127,10 @@ void MCStack::view_copy(const MCStack &p_view)
 
 	// IM-2014-01: [[ HiDPI ]] Initialize the view backing surface scale
 	m_view_backing_scale = p_view.m_view_backing_scale;
+
+    // SN-2014-14-10: [[ ViewRect ]] Ensure that the view rect is copied (uninitialised m_view_rect
+    //  might lead to a crash)
+    m_view_rect = p_view.m_view_rect;
 }
 
 void MCStack::view_destroy(void)

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,10 @@ void MCStack::view_copy(const MCStack &p_view)`
`127`	`127`
`128`	`128`	`// IM-2014-01: [[ HiDPI ]] Initialize the view backing surface scale`
`129`	`129`	`m_view_backing_scale = p_view.m_view_backing_scale;`
	`130`	`+`
	`131`	`+ // SN-2014-14-10: [[ ViewRect ]] Ensure that the view rect is copied (uninitialised m_view_rect`
	`132`	`+ // might lead to a crash)`
	`133`	`+ m_view_rect = p_view.m_view_rect;`
`130`	`134`	`}`
`131`	`135`
`132`	`136`	`void MCStack::view_destroy(void)`