Skip to content

Commit a4bc40f

Browse files
author
Bogdans
authored
Merge pull request TheThingsNetwork#2328 from TheThingsNetwork/fix/device-bulk-error-display
Fix error display in device import
2 parents 0876546 + 9077026 commit a4bc40f

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4444
- End device claim display bug when claim dates not set.
4545
- DeviceModeInd handling for LoRaWAN 1.1 devices.
4646
- Do not perform unnecessary gateway location updates.
47+
- Error display on failed end device import in the Console.
4748

4849
### Security
4950

pkg/webui/console/containers/device-importer/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { selectNsConfig, selectJsConfig, selectAsConfig } from '../../../lib/sel
2525
import DeviceImportForm from '../../components/device-import-form'
2626
import SubmitBar from '../../../components/submit-bar'
2727
import Button from '../../../components/button'
28-
import Notification from '../../../components/notification'
28+
import ErrorNotification from '../../../components/error-notification'
2929
import api from '../../api'
3030
import PropTypes from '../../../lib/prop-types'
3131
import Message from '../../../lib/components/message'
@@ -210,6 +210,7 @@ export default class DeviceImporter extends Component {
210210
} else if (status === 'finished') {
211211
statusMessage = m.operationFinished
212212
}
213+
213214
return (
214215
<div>
215216
<Message className={style.title} component="h4" content={operationMessage} />
@@ -229,7 +230,7 @@ export default class DeviceImporter extends Component {
229230
/>
230231
</React.Fragment>
231232
) : (
232-
<Notification small error={error} title={m.errorTitle} />
233+
<ErrorNotification small content={error} title={m.errorTitle} />
233234
)}
234235
<CodeEditor
235236
className={style.logOutput}

0 commit comments

Comments
 (0)