Remove occurrences of ssize_t

bartbes · bartbes · commit 711ab480af1e · 2019-02-03T13:39:17.000+01:00
Since apparently it's a POSIX-extension. For portability reasons use
auto instead, then always use an explicit cast on the result to silence
warnings.
diff --git a/src/common/PlaintextConnection.cpp b/src/common/PlaintextConnection.cpp
@@ -73,18 +73,18 @@ bool PlaintextConnection::connect(const std::string &hostname, uint16_t port)
 
 size_t PlaintextConnection::read(char *buffer, size_t size)
 {
-	ssize_t read = ::recv(fd, buffer, size, 0);
+	auto read = ::recv(fd, buffer, size, 0);
 	if (read < 0)
 		read = 0;
-	return read;
+	return static_cast<size_t>(read);
 }
 
 size_t PlaintextConnection::write(const char *buffer, size_t size)
 {
-	ssize_t written = ::send(fd, buffer, size, 0);
+	auto written = ::send(fd, buffer, size, 0);
 	if (written < 0)
 		written = 0;
-	return written;
+	return static_cast<size_t>(written);
 }
 
 void PlaintextConnection::close()

Original file line number	Diff line number	Diff line change
`@@ -73,18 +73,18 @@ bool PlaintextConnection::connect(const std::string &hostname, uint16_t port)`
`73`	`73`
`74`	`74`	`size_t PlaintextConnection::read(char *buffer, size_t size)`
`75`	`75`	`{`
`76`		`- ssize_t read = ::recv(fd, buffer, size, 0);`
	`76`	`+ auto read = ::recv(fd, buffer, size, 0);`
`77`	`77`	`if (read < 0)`
`78`	`78`	`read = 0;`
`79`		`- return read;`
	`79`	`+ return static_cast<size_t>(read);`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`size_t PlaintextConnection::write(const char *buffer, size_t size)`
`83`	`83`	`{`
`84`		`- ssize_t written = ::send(fd, buffer, size, 0);`
	`84`	`+ auto written = ::send(fd, buffer, size, 0);`
`85`	`85`	`if (written < 0)`
`86`	`86`	`written = 0;`
`87`		`- return written;`
	`87`	`+ return static_cast<size_t>(written);`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`void PlaintextConnection::close()`