Add NOMINMAX define

bartbes · bartbes · commit af96f6dd8b06 · 2019-02-03T13:19:29.000+01:00
Because the windows stdlib loves defining min and max, breaking
otherwise valid code calling std::min/std::max.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -2,6 +2,7 @@ cmake_minimum_required (VERSION 3.0)
 
 ### Basic compilation settings
 set (CMAKE_POSITION_INDEPENDENT_CODE TRUE)
+add_definitions (-DNOMINMAX)
 
 configure_file (
 	common/config.h.in
diff --git a/src/common/PlaintextConnection.cpp b/src/common/PlaintextConnection.cpp
@@ -8,8 +8,6 @@
 #else
 #	include <winsock2.h>
 #	include <ws2tcpip.h>
-#	undef min
-#	undef max
 #endif // USE_WINSOCK
 
 #include "PlaintextConnection.h"
