Add Filters.attachment (python-telegram-bot#2528)

Poolitzer · Bibo-Joshi · web-flow · commit cd69f69b282e · 2021-05-19T10:39:10.000+02:00
* feat: attachment filter

* fix: add versionadded statement

* Fix: small doc string changes

Co-authored-by: Bibo-Joshi &lt;hinrich.mahler@freenet.de&gt;

Co-authored-by: Bibo-Joshi &lt;hinrich.mahler@freenet.de&gt;
diff --git a/telegram/ext/filters.py b/telegram/ext/filters.py
@@ -2075,6 +2075,18 @@ def filter(self, message: Message) -> bool:
                 and any(message.from_user.language_code.startswith(x) for x in self.lang)
             )
 
+    class _Attachment(MessageFilter):
+        name = 'Filters.attachment'
+
+        def filter(self, message: Message) -> bool:
+            return bool(message.effective_attachment)
+
+    attachment = _Attachment()
+    """Messages that contain :meth:`telegram.Message.effective_attachment`.
+
+
+        .. versionadded:: 13.6"""
+
     class _UpdateType(UpdateFilter):
         name = 'Filters.update'
 
diff --git a/tests/test_filters.py b/tests/test_filters.py
@@ -2173,3 +2173,18 @@ def test_filters_via_bot_repr(self):
 
         with pytest.raises(RuntimeError, match='Cannot set name'):
             f.name = 'foo'
+
+    def test_filters_attachment(self, update):
+        assert not Filters.attachment(update)
+        # we need to define a new Update (or rather, message class) here because
+        # effective_attachment is only evaluated once per instance, and the filter relies on that
+        up = Update(
+            0,
+            Message(
+                0,
+                datetime.datetime.utcnow(),
+                Chat(0, 'private'),
+                document=Document("str", "other_str"),
+            ),
+        )
+        assert Filters.attachment(up)
