cleaned up some brittle specs in hyper-component

catmando · catmando · commit 7795ff150ed6 · 2019-07-25T13:50:40.000-04:00
diff --git a/ruby/hyper-component/spec/client_features/dsl_spec.rb b/ruby/hyper-component/spec/client_features/dsl_spec.rb
@@ -65,7 +65,8 @@ class Foo
         end
       end
     end
-    expect(page.body).to match(/<input data-foo="12" data-reactroot="" \/>/)
+    expect(find('input')['data-reactroot']).to eq('')
+    expect(find('input')['data-foo']).to eq('12')
   end
 
   it "will turn the last string in a block into a element" do
@@ -287,11 +288,11 @@ class Foo
       class Foo
         include Hyperstack::Component
         render do
-          DIV(title: { bar: :foo })
+          DIV(id: :div, title: { bar: :foo }) { 'the div' }
         end
       end
     end
-    expect(page.body[-80..-19]).to include('<div title="{&quot;bar&quot;=&gt;&quot;foo&quot;}"></div>')
+    expect(find('#div')['title']).to eq('{"bar"=>"foo"}')
   end
 
   it "will remove all elements passed as params from the rendering buffer" do
diff --git a/ruby/hyper-component/spec/client_features/element_spec.rb b/ruby/hyper-component/spec/client_features/element_spec.rb
@@ -28,7 +28,12 @@ class Foo
           end
         end
       end
-      expect(page.body[-285..-233]).to match(/<input (type="text" value=""|value="" type="text").*\/>/)
+      # these checks are really not doing anything except making sure a proper
+      # input tag is created as expected.  However if false, nil, or a blank event
+      # name was not filtered errors would be raised during rendering which will
+      # throw errors.
+      expect(find('input')['type']).to eq('text')
+      expect(find('input')['value']).to eq('')
     end
   end
 
