Skip to content

Commit c7cf560

Browse files
author
Christian Garling
committed
Fixed python::virtualenv
* added ${pip_cmd} install --upgrade pip to have a recent pip version installed, the python::virtualenv function failed with pip 1.4.1 * replaced --no-use-wheel with --no-binary :all: as a dependency of recent pip version
1 parent 0a03cf2 commit c7cf560

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

manifests/virtualenv.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
$pip_cmd = "${python::exec_prefix}${venv_dir}/bin/pip"
160160

161161
exec { "python_virtualenv_${venv_dir}":
162-
command => "true ${proxy_command} && ${virtualenv_cmd} ${system_pkgs_flag} -p ${python} ${venv_dir} && ${pip_cmd} wheel --help > /dev/null 2>&1 && { ${pip_cmd} wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-use-wheel'; } ; { ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} \$wheel_support_flag --upgrade pip ${distribute_pkg} || ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} --upgrade pip ${distribute_pkg} ;}",
162+
command => "true ${proxy_command} && ${virtualenv_cmd} ${system_pkgs_flag} -p ${python} ${venv_dir} && ${pip_cmd} install --upgrade pip && ${pip_cmd} wheel --help > /dev/null 2>&1 && { ${pip_cmd} wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-binary :all:'; } ; { ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} \$wheel_support_flag --upgrade pip ${distribute_pkg} || ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} --upgrade pip ${distribute_pkg} ;}",
163163
user => $owner,
164164
creates => "${venv_dir}/bin/activate",
165165
path => $path,
@@ -171,7 +171,7 @@
171171

172172
if $requirements {
173173
exec { "python_requirements_initial_install_${requirements}_${venv_dir}":
174-
command => "${pip_cmd} wheel --help > /dev/null 2>&1 && { ${pip_cmd} wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-use-wheel'; } ; ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} \$wheel_support_flag -r ${requirements} ${extra_pip_args}",
174+
command => "${pip_cmd} wheel --help > /dev/null 2>&1 && { ${pip_cmd} wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-binary :all:'; } ; ${pip_cmd} --log ${venv_dir}/pip.log install ${pypi_index} ${proxy_flag} \$wheel_support_flag -r ${requirements} ${extra_pip_args}",
175175
refreshonly => true,
176176
timeout => $timeout,
177177
user => $owner,

0 commit comments

Comments
 (0)