Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vfr/Reader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: matthiask/Reader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 18, 2014

  1. Start introducing minimal changes for supporting dual page view

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    01f5b4b View commit details
    Browse the repository at this point in the history

  2. Advance two pages when swiping in landscape mode

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    33797dc View commit details
    Browse the repository at this point in the history

  3. Show / hide the navigation controller bar when tapping

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    a2ba339 View commit details
    Browse the repository at this point in the history

  4. Completely regenerate all content views when rotating

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    96e4a42 View commit details
    Browse the repository at this point in the history

  5. Top-down control of dual page viewing instead of littering the code w… 

    …ith orientation queries
    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    7021cb6 View commit details
    Browse the repository at this point in the history

  6. Off-by-one error for an even amount of pages

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    44c8252 View commit details
    Browse the repository at this point in the history

  7. Enumerate a copy, thou shall not modify arrays in place 

    Better be safe.
    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    d024acc View commit details
    Browse the repository at this point in the history

  8. Fix a few warnings related to integer precision

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    3ab723f View commit details
    Browse the repository at this point in the history

  9. Comment out an unused variable

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    538ae1a View commit details
    Browse the repository at this point in the history

  10. Could not move past the first page in portrait mode anymore

    @matthiask
    matthiask committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    74faac9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2014

  1. Remove some inserted code related to the navigation controller

    @matthiask
    matthiask committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    a8a6be1 View commit details
    Browse the repository at this point in the history

  2. Reindent reader files with tabs as the surrounding code

    @matthiask
    matthiask committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    8dd183e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2014

  1. Further minimize the diff

    @matthiask
    matthiask committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    35459f0 View commit details
    Browse the repository at this point in the history

  2. Add a comment explaining the size relationship when dual paging

    @matthiask
    matthiask committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    9556dd1 View commit details
    Browse the repository at this point in the history

  3. Additional bounds checking

    @matthiask
    matthiask committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    ec866e2 View commit details
    Browse the repository at this point in the history
Loading